[PR #50] [CLOSED] Removed unnecessary pieces of code #959

Closed
opened 2026-02-27 15:52:37 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/50
Author: @yankejustin
Created: 4/9/2015
Status: Closed

Base: masterHead: master


📝 Commits (2)

  • 7acde73 Removed unnecessary null check
  • 98cfd7d Removed unnecessary Stream

📊 Changes

2 files changed (+0 additions, -7 deletions)

View changed files

📝 Client/Core/Commands/CommandHandler.cs (+0 -4)
📝 Server/Core/Commands/CommandHandler.cs (+0 -3)

📄 Description

Removed unnecessary null check (duplicate null check, was already checked in the method!), and removed an unnecessary Stream that was created when the Client is commanded to visit a URL. We already got the response, so we don't need to do anything further!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/50 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 4/9/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`7acde73`](https://github.com/quasar/Quasar/commit/7acde73f3db69772bb22c8d05ac0dc6a20d980fa) Removed unnecessary null check - [`98cfd7d`](https://github.com/quasar/Quasar/commit/98cfd7d484d6320112e9f21ab2aeb66def82fdff) Removed unnecessary Stream ### 📊 Changes **2 files changed** (+0 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `Client/Core/Commands/CommandHandler.cs` (+0 -4) 📝 `Server/Core/Commands/CommandHandler.cs` (+0 -3) </details> ### 📄 Description Removed unnecessary null check (duplicate null check, was already checked in the method!), and removed an unnecessary Stream that was created when the Client is commanded to visit a URL. We already got the response, so we don't need to do anything further! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 15:52:37 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Quasar#959
No description provided.