[PR #24] [MERGED] Code consistency, clarity, and improvements #942

New issue

Closed

opened 2026-02-27 15:52:33 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/24
Author: @yankejustin
Created: 3/18/2015
Status: ✅ Merged
Merged: 3/18/2015
Merged by: @MaxXor

Base: master ← Head: master

📝 Commits (6)

4856568 Merge pull request #3 from MaxXor/master
6243e47 CommandHandler Bitmap Disposal
7fd83c8 Removed label to increase readability
79f9ca0 Made sure the TcpClient will always kill itself
c6b57f8 Dispose of the memory stream in Helper class
b95f7f9 Disposed of process on the shell closing

📊 Changes

5 files changed (+78 additions, -51 deletions)

View changed files

📝 Client/Core/Commands/CommandHandler.cs (+10 -10)
📝 Client/Core/RemoteShell/Shell.cs (+7 -1)
📝 Server/Core/Commands/CommandHandler.cs (+25 -24)
📝 Server/Core/Helper/Helper.cs (+5 -3)
📝 Server/Core/Helper/UPnP.cs (+31 -13)

📄 Description

Mostly non-functional changes to improve the clarity and quality of the code. Some changes to the code to make sure correct/intended behavior is enforced.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/24 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 3/18/2015 **Status:** ✅ Merged **Merged:** 3/18/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`4856568`](https://github.com/quasar/Quasar/commit/4856568bffdf858777ca084529e7f0e7ac8f9bd3) Merge pull request #3 from MaxXor/master - [`6243e47`](https://github.com/quasar/Quasar/commit/6243e470b46701564cc029978111b2e8d2f53a06) CommandHandler Bitmap Disposal - [`7fd83c8`](https://github.com/quasar/Quasar/commit/7fd83c87bebc409c36b99cde5e22829e313bc56d) Removed label to increase readability - [`79f9ca0`](https://github.com/quasar/Quasar/commit/79f9ca0cbab2559375523b0c8ac1ce6b0e77a3cc) Made sure the TcpClient will always kill itself - [`c6b57f8`](https://github.com/quasar/Quasar/commit/c6b57f8110646909ff2bd3bea8e7276f4276df3e) Dispose of the memory stream in Helper class - [`b95f7f9`](https://github.com/quasar/Quasar/commit/b95f7f9268f93a1233c5fbd43d03c2461a470636) Disposed of process on the shell closing ### 📊 Changes **5 files changed** (+78 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `Client/Core/Commands/CommandHandler.cs` (+10 -10) 📝 `Client/Core/RemoteShell/Shell.cs` (+7 -1) 📝 `Server/Core/Commands/CommandHandler.cs` (+25 -24) 📝 `Server/Core/Helper/Helper.cs` (+5 -3) 📝 `Server/Core/Helper/UPnP.cs` (+31 -13) </details> ### 📄 Description Mostly non-functional changes to improve the clarity and quality of the code. Some changes to the code to make sure correct/intended behavior is enforced. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>