[PR #19] [MERGED] Behavior Consistency and Memory Leaks #938

New issue

Closed

opened 2026-02-27 15:52:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/19
Author: @yankejustin
Created: 3/16/2015
Status: ✅ Merged
Merged: 3/17/2015
Merged by: @MaxXor

Base: master ← Head: master

📝 Commits (3)

c6c1cb2 Improved Behavior
0f0cf6e Memory Leak fixes
79588d4 Dispose of the stream

📊 Changes

4 files changed (+146 additions, -91 deletions)

View changed files

📝 Client/Core/Commands/CommandHandler.cs (+43 -33)
📝 Client/Core/Information/GeoIP.cs (+22 -14)
📝 Client/Core/SystemCore.cs (+80 -44)
📝 Server/Core/ProtoBuf/ProtoWriter.cs (+1 -0)

📄 Description

Added a few try-finally blocks to make sure that, even if an exception is thrown, behavior remains more consistent.
Also added a few using blocks to make sure that, if the method returns or an exception is thrown, we can avoid a memory leak. (Common in cases where dispose is called at the bottom of a try-catch block... If an exception was thrown, it wouldn't reach the dispose call).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/19 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 3/16/2015 **Status:** ✅ Merged **Merged:** 3/17/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`c6c1cb2`](https://github.com/quasar/Quasar/commit/c6c1cb20227b525dc698db3ddd7819564a0b8165) Improved Behavior - [`0f0cf6e`](https://github.com/quasar/Quasar/commit/0f0cf6ed4c0cf0d03e2c1b07bcdd1f76a9d90c72) Memory Leak fixes - [`79588d4`](https://github.com/quasar/Quasar/commit/79588d4ea889ad1a1d276ba984ca0f1bc53b226c) Dispose of the stream ### 📊 Changes **4 files changed** (+146 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `Client/Core/Commands/CommandHandler.cs` (+43 -33) 📝 `Client/Core/Information/GeoIP.cs` (+22 -14) 📝 `Client/Core/SystemCore.cs` (+80 -44) 📝 `Server/Core/ProtoBuf/ProtoWriter.cs` (+1 -0) </details> ### 📄 Description Added a few try-finally blocks to make sure that, even if an exception is thrown, behavior remains more consistent. Also added a few using blocks to make sure that, if the method returns or an exception is thrown, we can avoid a memory leak. (Common in cases where dispose is called at the bottom of a try-catch block... If an exception was thrown, it wouldn't reach the dispose call). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>