[PR #2] [CLOSED] Refactored Code & Extracted Types #932

New issue

Closed

opened 2026-02-27 15:52:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/2
Author: @iflyairplanes
Created: 7/27/2014
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (4)

30f12d1 Refactoring and Type Extraction
960468b Initial Commit
880c465 gitignore update
9f0b84a Removing jtconfig's

📊 Changes

310 files changed (+11459 additions, -6686 deletions)

View changed files

📝 .gitignore (+4 -1)
📝 Client/Client.csproj (+10 -2)
📝 Client/Config/Settings.cs (+3 -2)
📝 Client/Core/Client.cs (+23 -21)
📝 Client/Core/Commands/CommandHandler.cs (+571 -544)
📝 Client/Core/Compression/LZ4/LZ4Compressor32.cs (+256 -110)
📝 Client/Core/Compression/LZ4/LZ4Decompressor32.cs (+162 -41)
📝 Client/Core/Compression/LZ4/LZ4Util.cs (+16 -6)
📝 Client/Core/Elevation/CommandButton.cs (+1 -1)
📝 Client/Core/Elevation/frmElevation.cs (+42 -28)
📝 Client/Core/Encryption/AES.cs (+2 -2)
📝 Client/Core/Encryption/RC4.cs (+8 -8)
📝 Client/Core/GeoIP.cs (+16 -8)
📝 Client/Core/Helper/Helper.cs (+20 -14)
➕ Client/Core/OSInfo.cs (+820 -0)
📝 Client/Core/Packets/ClientPackets/Commands/DesktopResponse.cs (+4 -1)
📝 Client/Core/Packets/ClientPackets/Commands/DirectoryResponse.cs (+4 -1)
📝 Client/Core/Packets/ClientPackets/Commands/DownloadFileResponse.cs (+4 -1)
📝 Client/Core/Packets/ClientPackets/Commands/DrivesResponse.cs (+4 -1)
📝 Client/Core/Packets/ClientPackets/Commands/GetProcessesResponse.cs (+4 -1)

...and 80 more files

📄 Description

Refactored a lot of the code
Removed a lot of redundant code
Changed a lot of explicit types to vars
Optimized and removed unused using

Began renaming some variables and classes to use the MSDN C# guidelines.

*TODO: * finish entire migration to proper naming.

Types and namespaces: UpperCamelCase,
Interfaces: IUpperCamelCase,
Public methods, properties, fields, events: UpperCamelCase,
Private/protected methods, properties, fields: lowerCamelCase (no damn prefixes),
Static readonly/const fields: ALL_UPPER.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/2 **Author:** [@iflyairplanes](https://github.com/iflyairplanes) **Created:** 7/27/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`30f12d1`](https://github.com/quasar/Quasar/commit/30f12d18e29a10570d666551f45c819a9b560de9) Refactoring and Type Extraction - [`960468b`](https://github.com/quasar/Quasar/commit/960468b9617b7ed8f92d60795d03d9bcb9ae5f30) Initial Commit - [`880c465`](https://github.com/quasar/Quasar/commit/880c465950c0a442bfbf29b42120fdb65631e44e) gitignore update - [`9f0b84a`](https://github.com/quasar/Quasar/commit/9f0b84a8ab8cac7fc7f592af5622d1692df25fb9) Removing jtconfig's ### 📊 Changes **310 files changed** (+11459 additions, -6686 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+4 -1) 📝 `Client/Client.csproj` (+10 -2) 📝 `Client/Config/Settings.cs` (+3 -2) 📝 `Client/Core/Client.cs` (+23 -21) 📝 `Client/Core/Commands/CommandHandler.cs` (+571 -544) 📝 `Client/Core/Compression/LZ4/LZ4Compressor32.cs` (+256 -110) 📝 `Client/Core/Compression/LZ4/LZ4Decompressor32.cs` (+162 -41) 📝 `Client/Core/Compression/LZ4/LZ4Util.cs` (+16 -6) 📝 `Client/Core/Elevation/CommandButton.cs` (+1 -1) 📝 `Client/Core/Elevation/frmElevation.cs` (+42 -28) 📝 `Client/Core/Encryption/AES.cs` (+2 -2) 📝 `Client/Core/Encryption/RC4.cs` (+8 -8) 📝 `Client/Core/GeoIP.cs` (+16 -8) 📝 `Client/Core/Helper/Helper.cs` (+20 -14) ➕ `Client/Core/OSInfo.cs` (+820 -0) 📝 `Client/Core/Packets/ClientPackets/Commands/DesktopResponse.cs` (+4 -1) 📝 `Client/Core/Packets/ClientPackets/Commands/DirectoryResponse.cs` (+4 -1) 📝 `Client/Core/Packets/ClientPackets/Commands/DownloadFileResponse.cs` (+4 -1) 📝 `Client/Core/Packets/ClientPackets/Commands/DrivesResponse.cs` (+4 -1) 📝 `Client/Core/Packets/ClientPackets/Commands/GetProcessesResponse.cs` (+4 -1) _...and 80 more files_ </details> ### 📄 Description Refactored a lot of the code Removed a lot of redundant code Changed a lot of explicit types to vars Optimized and removed unused using Began renaming some variables and classes to use the [MSDN C# guidelines](http://msdn.microsoft.com/en-us/library/ms229002%28v=vs.110%29.aspx). *_TODO: *_ finish entire migration to proper naming. - Types and namespaces: **UpperCamelCase**, - Interfaces: **IUpperCamelCase**, - Public methods, properties, fields, events: **UpperCamelCase**, - Private/protected methods, properties, fields: **lowerCamelCase** (no damn prefixes), - Static readonly/const fields: **ALL_UPPER**. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>