mirror of
https://github.com/quasar/Quasar.git
synced 2026-04-25 23:35:58 +03:00
[GH-ISSUE #167] Keylogger Cross-Site Scripting (XSS) vulnerability #72
Labels
No labels
bug
bug
cant-reproduce
discussion
duplicate
easy
enhancement
help wanted
improvement
invalid
need more info
pull-request
question
wont-add
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Quasar#72
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yankejustin on GitHub (May 23, 2015).
Original GitHub issue: https://github.com/quasar/Quasar/issues/167
Originally assigned to: @MaxXor on GitHub.
Background
- Cross-Site Scripting is a common issue with websites of today. Consider a comment box that receives the following comment by a user: "Hello, everyone! I am just a>script>alert('xss')>/script>normal user". (Note: I have inverted the beginning and ending<tag because of Github's filter) - The situation above, if done on a vulnerable website, would cause anyone viewing the website to see: "Hello, everyone! I am just a normal user." in the comment section. An additional effect would be the browser rendering the script literally, causing a message box to open up (seen on Figure 1 below). - This affect is extremely dangerous because one exploiting such a vulnerability can redirect users to cause execution of arbitrary code.Attack Vector (steps for exploitation)
1. Build client files, initialize the server, and build a client with keylogging enabled. 2. Initialize the client. On the client machine, type the following:  3. On the server, get the logs from the client and open the file. Notice the message box popup.Additional Notes
Does this cause an adverse affect on the accuracy of the keylogger?
No. The log file is unaffected; opening the log file in something like Notepad would reveal that it is accurate. However, because the log file is parsed by the WebBrowser control on the FrmKeylogger Form, these tags will be translated literally by the WebBrowser, so the log file will not appear on the Form to be as it is on the actual file.
What other inputs will be affected by this issue?
All HTML tags. These tags are rendered literally. Try to type
>hr />(Note: Type a<for the beginning of thehrtag).Figure 1
@yankejustin commented on GitHub (May 23, 2015):
@MaxXor This is also a high priority issue that must be fixed before we merge
devintomaster... I just felt it deserved to be in its own issue. 💩@MaxXor commented on GitHub (May 23, 2015):
This should be fixed in the latest commit.