mirror of
https://github.com/quasar/Quasar.git
synced 2026-04-25 15:25:59 +03:00
[GH-ISSUE #153] Client crashes when Stop Listening on server #71
Labels
No labels
bug
bug
cant-reproduce
discussion
duplicate
easy
enhancement
help wanted
improvement
invalid
need more info
pull-request
question
wont-add
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Quasar#71
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DragonzMaster on GitHub (May 19, 2015).
Original GitHub issue: https://github.com/quasar/Quasar/issues/153
As shown in the title
When the client is running and i stop listening (Server) the client crash
Client.exe has Stopped Working
So anyone else faces this problem ?
@MaxXor commented on GitHub (May 19, 2015):
Working fine for me here. I can stop and start listening and the client connects again.
@DragonzMaster commented on GitHub (May 19, 2015):
hmmmm it is really strange
i tried again and the client still crashes
@ghost commented on GitHub (May 19, 2015):
Yes it is doing it for me as well. I will investigate. This is with the most recent master-branch
@MaxXor commented on GitHub (May 19, 2015):
Start the client in debug mode and the Server normally. Then reproduce the crash and the Debugger will stop at the exception. Plesse tell me as much as Visual Studio tells you, like name, line number. :)
@ghost commented on GitHub (May 19, 2015):
@MaxXor, I first started the client normally by building it, stopping the listen server the client crashed. It doesn't crash in debug however
I will look at the dump and find the exception thrown
@DragonzMaster commented on GitHub (May 19, 2015):
no in the debug mode the client works smoothly and never crash @MaxXor
it seems that the problem with release mode 😥
@ghost commented on GitHub (May 19, 2015):
It is throwing a System.TypeLoadException. Probably something in the Servers renamer class
@DragonzMaster commented on GitHub (May 19, 2015):
i remember that the renamer caused a problem with the previous Keylogger also
so can it be the problem like what @d3agle said ??
@ghost commented on GitHub (May 19, 2015):
This is the error message I'm getting in Visual studio 2015:
System.TypeLoadException was unhandled
Message: An unhandled exception of type 'System.TypeLoadException' occurred in Client-built.exe
Additional information: Method 'Dispose' in type '䬖從晃쯓ⰷ샡躥䇆뎿㕵ด瓐㙏䈁䢫쯻' from assembly 'Client, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.
@ghost commented on GitHub (May 19, 2015):
Is there any way to exclude obfuscating types that implement the IDisposable interface?
Edit: I think i fixed it. Client no longer crashes. I will pull request, please let me know if this is acceptable way of fixing this.
@ghost commented on GitHub (May 19, 2015):
Sent a pull request #154 for this fix
@DragonzMaster commented on GitHub (May 19, 2015):
i hope it fixed the problem @d3agle
@DragonzMaster commented on GitHub (May 19, 2015):
@MaxXor please can we make the renamer optional ??
EDIT : When Uninstalling the client the same problem happens and the client crashes before it is deleted
@yankejustin commented on GitHub (May 19, 2015):
@DragonzMaster To clarify, do you mean that it crashes before deletion and does not create the batch file that deletes itself?
@DragonzMaster commented on GitHub (May 20, 2015):
no it crashes and ("client.exe has stopped working) appears then it is deleted @yankejustin
@yankejustin commented on GitHub (May 20, 2015):
@DragonzMaster Try it again and see if it still does that. :)
@DragonzMaster commented on GitHub (May 20, 2015):
It seems that both of the 2 fixes work
not one of them only as i had to fix both of the renemer and the shell to get the problem fixedit took 15-20 seconds to uninstall
EDIT : _d3agle_ fix solves the 2 issues (uninstalling & stop listening)
@yankejustin commented on GitHub (May 20, 2015):
So both fixes fix both of your issues?
@DragonzMaster commented on GitHub (May 20, 2015):
yes 😃
I tried again with @d3agle fix only and it seems to fix both issues (really sorry i didn't notice that the first time i tested the client)
and i think the try-catch block you have made won't hurt 😆 @yankejustin
thanks for both of you ... good work
@yankejustin commented on GitHub (May 20, 2015):
Yeah you're right. ;)
If the process was already terminating the client would discontinue working as described above. It would not even be able to uninstall correctly. 🍗