mirror of
https://github.com/quasar/Quasar.git
synced 2026-04-26 07:45:57 +03:00
[GH-ISSUE #973] [Question] How to add a new option in Profile Builder ? #684
Labels
No labels
bug
bug
cant-reproduce
discussion
duplicate
easy
enhancement
help wanted
improvement
invalid
need more info
pull-request
question
wont-add
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Quasar#684
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mehroz1 on GitHub (Jun 2, 2021).
Original GitHub issue: https://github.com/quasar/Quasar/issues/973
Sorry for opening an issue here but I am stuck on this problem for two days. I am trying add to new option to allow client to connect to a website. I have connected the client to website but the link of the website is hard coded in client at the moment. Now I want to add link of the website to profile builder so it can be changed when a new client is generated. The problem is I can't seem to figure out how Quasar\Server\Build\ClientBuilder.cs is injecting values Client.bin and how Quasar\Client\Config\Settings.cs is able to read them.
Here is my ClientBuilder.cs:
Here is my Settings.cs:

Can anyone tell me what I am doing wrong here? I am trying to send unencrypted url link to Client.bin but when client is executed i receive an empty string. Any help would be much appreciated.
@MaxXor commented on GitHub (Jun 2, 2021):
Looks correct. Check out this commit:
github.com/quasar/Quasar@053890b933 (diff-0de2da8eed)In this commit a new option (boolean) was added, but string is almost the same. Hope it does help you.
@mehroz1 commented on GitHub (Jun 3, 2021):
Thank you
@mehroz1 commented on GitHub (Jun 3, 2021):
Here is an update
in Quasar\Client\Settings.cs I moved this line
public static string CONTROLDOMAIN = "";from line 73 to 70 and placed it above install path and log path it started working.
I don't understand how Quasar is mapping variables. I mean I can't see any pattern here. Is there any way I can know for sure that I am not disturbing any other static member?
I thoroughly studied your commit and you were able to add UNATTENDEDMODE without any changes in line order.
@MaxXor commented on GitHub (Jun 7, 2021):
Glad you got it working. The order of the properties in the
Settings.csfile is important. As you can see in theWriteSettingsmethod in your first screenshot it uses the order of the strings/bools/ints in the switch/case statements there too. You can check out the order by viewing the decompiled code in ilSpy/dnSpy. Not sure why you had to moveCONTROLDOMAINaboveINSTALLPATHas that mixes the settings of the last 3 strings. 🤔@mehroz1 commented on GitHub (Jun 8, 2021):
@MaxXor Yes it should mix up the string that was my initial preception as this was the case with any other position but the output I was getting via Release & Debug showed that each variable was being assigned correct value ( unless the INSTALLPATH is malfunctioning ). I will still inspect the project with ilSpy.