starred/Quasar

Fork 0

mirror of https://github.com/quasar/Quasar.git synced 2026-04-26 07:45:57 +03:00

[GH-ISSUE #130] Common classes #65

New issue

Closed

opened 2026-02-27 15:48:34 +03:00 by kerem · 7 comments

kerem commented

2026-02-27 15:48:34 +03:00

Owner

Originally created by @tidusjar on GitHub (May 14, 2015).
Original GitHub issue: https://github.com/quasar/Quasar/issues/130

Hi,

I have a question why we are duplicating work?
There seems to be a few 'common' classes in the solution where they are duplicated in both projects. e.g. encryption. Why do we not have a 'Common' Project with these classes in that the other projects just reference?

Originally created by @tidusjar on GitHub (May 14, 2015). Original GitHub issue: https://github.com/quasar/Quasar/issues/130 Hi, I have a question why we are duplicating work? There seems to be a few 'common' classes in the solution where they are duplicated in both projects. e.g. encryption. Why do we not have a 'Common' Project with these classes in that the other projects just reference?

kerem

2026-02-27 15:48:34 +03:00

closed this issue
added the
question
label

kerem commented

2026-02-27 15:48:34 +03:00

Author

Owner

@MaxXor commented on GitHub (May 14, 2015):

I want the client to have no dependencies except the default ones from the .net framework.

@MaxXor commented on GitHub (May 14, 2015): I want the client to have no dependencies except the default ones from the .net framework.

kerem commented

2026-02-27 15:48:34 +03:00

Author

Owner

@tidusjar commented on GitHub (May 14, 2015):

Why can't we have a dependency on our own controlled, small library? I'm just thinking it would help out with the project structure and maintainability.

@tidusjar commented on GitHub (May 14, 2015): Why can't we have a dependency on our own controlled, small library? I'm just thinking it would help out with the project structure and maintainability.

kerem commented

2026-02-27 15:48:34 +03:00

Author

Owner

@yankejustin commented on GitHub (May 14, 2015):

@MaxXor I think you may have misunderstood @tidusjar
If I am understanding correctly, tidusjar is suggesting that we move code that is the same for the server and the client (for example: protobuf) to another project and have the server and use the same project so we don't have to make a change to the server or client, then reflect the change to the other project. Doing this would mean we only have to change one and it would be unnecessary to require a duplicate change in the other project.

@yankejustin commented on GitHub (May 14, 2015): @MaxXor I think you may have misunderstood @tidusjar If I am understanding correctly, tidusjar is suggesting that we move code that is the same for the server and the client (for example: protobuf) to another project and have the server and use the same project so we don't have to make a change to the server or client, then reflect the change to the other project. Doing this would mean we only have to change one and it would be unnecessary to require a duplicate change in the other project.

kerem commented

2026-02-27 15:48:35 +03:00

Author

Owner

@tidusjar commented on GitHub (May 14, 2015):

@yankejustin Correct. We would then only make the change in one location and it would be consistent across the server and client. But it would require 1 more .DLL

@tidusjar commented on GitHub (May 14, 2015): @yankejustin Correct. We would then only make the change in one location and it would be consistent across the server and client. But it would require 1 more .DLL

kerem commented

2026-02-27 15:48:35 +03:00

Author

Owner

@MaxXor commented on GitHub (May 14, 2015):

@tidusjar and I don't allow this one more DLL, sorry.

@MaxXor commented on GitHub (May 14, 2015): @tidusjar and I don't allow this one more DLL, sorry.

kerem commented

2026-02-27 15:48:35 +03:00

Author

Owner

@rabbitsmith commented on GitHub (May 25, 2015):

@MaxXor i think this is feasible.we can use ilmerge to combine the protobuf dll , encryption dll and client.exe after compiling them. simply search in google for ilmerge.exe.

@rabbitsmith commented on GitHub (May 25, 2015): @MaxXor i think this is feasible.we can use ilmerge to combine the protobuf dll , encryption dll and client.exe after compiling them. simply search in google for ilmerge.exe.

kerem commented

2026-02-27 15:48:35 +03:00

Author

Owner

@rabbitsmith commented on GitHub (May 25, 2015):

we can merge mono.cecil with xrat.exe

@rabbitsmith commented on GitHub (May 25, 2015): we can merge mono.cecil with xrat.exe

kerem referenced this issue

2026-02-27 15:52:39 +03:00

[PR #65] [MERGED] SystemInfo as ToolTip #972