[GH-ISSUE #857] FileChunk Int32 overflow #582

New issue

Closed

opened 2026-02-27 15:50:59 +03:00 by kerem · 1 comment

kerem commented

2026-02-27 15:50:59 +03:00

Owner

Originally created by @devcore256 on GitHub (Jul 27, 2020).
Original GitHub issue: https://github.com/quasar/Quasar/issues/857

Description
File downloading is not work correctly for files larger than Int32.MaxValue (2147483647 bytes). You will get error message from client "Error reading file" when you try _fileStream.Seek(offset, SeekOrigin.Begin); in method ReadChunk(long offset).

Bug in class Quasar.Common.IO.FileSplit

public IEnumerator<FileChunk> GetEnumerator()
        {
            for (int currentChunk = 0; currentChunk <= _fileStream.Length / MaxChunkSize; currentChunk++)
            {
                yield return ReadChunk(currentChunk * MaxChunkSize);
            }
        }

When pass arg to ReadChunk method currentChunk * MaxChunkSize is casting to Int32. We must declare currentChunk as long.

Expected behavior

public IEnumerator<FileChunk> GetEnumerator()
        {
            for (long currentChunk = 0; currentChunk <= _fileStream.Length / MaxChunkSize; currentChunk++)
            {
                yield return ReadChunk(currentChunk * MaxChunkSize);
            }
        }

Originally created by @devcore256 on GitHub (Jul 27, 2020). Original GitHub issue: https://github.com/quasar/Quasar/issues/857 **Description** File downloading is not work correctly for files larger than Int32.MaxValue (**2147483647 bytes**). You will get error message from client "Error reading file" when you try `_fileStream.Seek(offset, SeekOrigin.Begin);` in method ReadChunk(long offset). Bug in class **Quasar.Common.IO.FileSplit** ``` public IEnumerator<FileChunk> GetEnumerator() { for (int currentChunk = 0; currentChunk <= _fileStream.Length / MaxChunkSize; currentChunk++) { yield return ReadChunk(currentChunk * MaxChunkSize); } } ``` When pass arg to ReadChunk method currentChunk * MaxChunkSize is casting to Int32. We must declare currentChunk as **long**. **Expected behavior** ``` public IEnumerator<FileChunk> GetEnumerator() { for (long currentChunk = 0; currentChunk <= _fileStream.Length / MaxChunkSize; currentChunk++) { yield return ReadChunk(currentChunk * MaxChunkSize); } } ```