mirror of
https://github.com/quasar/Quasar.git
synced 2026-04-25 23:35:58 +03:00
[GH-ISSUE #619] Methods renaming #374
Labels
No labels
bug
bug
cant-reproduce
discussion
duplicate
easy
enhancement
help wanted
improvement
invalid
need more info
pull-request
question
wont-add
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Quasar#374
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Powershell-coder on GitHub (Sep 13, 2017).
Original GitHub issue: https://github.com/quasar/Quasar/issues/619
Hi
I want to extend renamer.cs and rename all methods.
But may be there is some methods which renamed, client may crash or doesnt work correctly
Which methods MUST not be renamed ?
@life-coder commented on GitHub (Sep 15, 2017):
You can rename every method. Just be sure to rename all the references too
@yankejustin commented on GitHub (Sep 15, 2017):
It doesn't matter if you change the method names. You would only experience issues if you began to restructure the code (changing the namespace of certain classes mainly).
You can see the namespaces that dislike being renamed here.
@Powershell-coder commented on GitHub (Sep 17, 2017):
Yes
But i want to obfuscate the code with some obfuscators like .Net Reactor.
Its is needed NOT ot obfuscate some parts of code because if obfuscate all Client doesnt work.
Based on this only NetSerializer and Registry and typeDef.HasInterfaces can not be obfuscated.
Is it true ?
And what about Build option in Server. Does renaming has side effect on it and Must rename somthing in server ?
@MaxXor commented on GitHub (Oct 9, 2017):
@EhsanArio Yes, classes from NetSerializer & Registry namespace and classes with interfaces can not be renamed. It does have no negative side effects.