[GH-ISSUE #579] Inconsistent connection states #338

New issue

Open

opened 2026-02-27 15:49:56 +03:00 by kerem · 1 comment

kerem commented

2026-02-27 15:49:56 +03:00

Owner

Originally created by @chico-depressive on GitHub (Jan 18, 2017).
Original GitHub issue: https://github.com/quasar/Quasar/issues/579

else if (type == typeof(ServerPackets.DoClientDisconnect))
            {
                Program.ConnectClient.Exit(); 
            }
            else if (type == typeof(ServerPackets.DoClientReconnect))
            {
                Program.ConnectClient.Disconnect();
            }

disconnecting = exit and reconnect = disconnect?
providing a disconnecting without exiting should be a good idea

Originally created by @chico-depressive on GitHub (Jan 18, 2017). Original GitHub issue: https://github.com/quasar/Quasar/issues/579 ``` else if (type == typeof(ServerPackets.DoClientDisconnect)) { Program.ConnectClient.Exit(); } else if (type == typeof(ServerPackets.DoClientReconnect)) { Program.ConnectClient.Disconnect(); } ``` disconnecting = exit and reconnect = disconnect? providing a disconnecting without exiting should be a good idea

kerem added the

improvement

easy

labels

2026-02-27 15:49:56 +03:00

kerem commented

2026-02-27 15:49:57 +03:00

Author

Owner

@yankejustin commented on GitHub (Mar 21, 2017):

Referencing these lines of code.

The way those lines work goes like this: the client will reset its state and disconnect things like clients from the reverse proxy. An internal value is still held to make sure that the client will automatically reconnect. By the lack of comment and the naming of the method, I can see why that would be confusing to read in the code.

@yankejustin commented on GitHub (Mar 21, 2017): Referencing <a href="https://github.com/quasar/QuasarRAT/blob/64cb0e5f837954be59b484b42744661805b0a837/Client/Core/Packets/PacketHandler.cs#L22-L29">these lines</a> of code. The way those lines work goes like this: the client will reset its state and disconnect things like clients from the reverse proxy. An internal value is still held to make sure that the client will <i>automatically</i> reconnect. By the lack of comment and the naming of the method, I can see why that would be confusing to read in the code.

kerem referenced this issue

2026-02-27 15:53:08 +03:00

[PR #338] [MERGED] DialogBox fix #1107