mirror of
https://github.com/quasar/Quasar.git
synced 2026-04-25 15:25:59 +03:00
[GH-ISSUE #459] Buffer overflow when receiving multiple packets of 1-3 bytes #241
Labels
No labels
bug
bug
cant-reproduce
discussion
duplicate
easy
enhancement
help wanted
improvement
invalid
need more info
pull-request
question
wont-add
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Quasar#241
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Netskyes on GitHub (May 20, 2016).
Original GitHub issue: https://github.com/quasar/Quasar/issues/459
Originally assigned to: @MaxXor on GitHub.
Hi, so the issue occurs when client is processing packets and the readableDataLen is less than HEADER_SIZE, then it resets readableDataLen to 0 and gets ready to process new packet.
If the new packet size is also less than HEADER_SIZE, it will keep writing to _tempHeader and eventually (in case where a few packets size is less than HEADER_SIZE) cause buffer overflow.
@MaxXor commented on GitHub (May 20, 2016):
This usually doesn't happen often in normal program operation. But I'll take a look into it to fix it.
@Netskyes commented on GitHub (May 20, 2016):
I agree, but it still can happen so thought to let you know :)