mirror of
https://github.com/quasar/Quasar.git
synced 2026-04-25 15:25:59 +03:00
[GH-ISSUE #425] Registry Editor doesn't work correctly on 64-bit systems #216
Labels
No labels
bug
bug
cant-reproduce
discussion
duplicate
easy
enhancement
help wanted
improvement
invalid
need more info
pull-request
question
wont-add
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Quasar#216
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DragonzMaster on GitHub (Mar 10, 2016).
Original GitHub issue: https://github.com/quasar/Quasar/issues/425
I tried to use registry editor in release config but it seems to be not working even when I run the client with admin privil. but when I tried it using debug config it works good.
@LjungErik commented on GitHub (Mar 10, 2016):
It seems like the registry editor keeps crashing after load, when running as a Release build. I will look into this more and keep you posted on what I find.
@DragonzMaster commented on GitHub (Mar 11, 2016):
ok, thanks in advance.
@DragonzMaster commented on GitHub (Mar 11, 2016):
I forget to mention that when I tried to view values in HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run it get the values from the same key but Current user not local machine
so it need to be fixed too, and make it view the values from the correct key
EDIT: the problem seems to be not about local machine and current user but about :
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run
and
WOWNode64\Microsoft\Windows\CurrentVersion\Run
@LjungErik commented on GitHub (Mar 14, 2016):
@DragonzMaster I have looked at the
HKEY_LOCAL_MACHINEregistry but can't seem to recreate your error. However, I have found that theRegistryEditoronly seems to work against the 64-bit registry (even if the Client is 32-bit).@DragonzMaster commented on GitHub (Mar 14, 2016):
What I mean that when I open
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run
it shows the values from the key below instead of the correct key
HKEY_LOCAL_MACHINE\ WOWNode64 \SOFTWARE\Microsoft\Windows\CurrentVersion\Run
@LjungErik commented on GitHub (Mar 15, 2016):
Ok, seems that this is what I mentioned about the
RegistryEditoronly working against the 64-bit registry. In the future this should probably be extended to make it possible to edit both 64-bit and 32-bit registry values/keys, however I will put this on hold and handle it in later updates.@MaxXor commented on GitHub (Mar 15, 2016):
@StingRaptor The client registryeditor is working partially on 64-bit systems. As @DragonzMaster said. For example when you try to access keys from
HKEY_LOCAL_MACHINE\SOFTWARE\*it will give you instead the keys fromHKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\*on 64-bit systems.Same for
HKEY_CURRENT_USER\Software\*.On 32-bit systems it's working correctly.
We will need to add the enum
RegistryView(https://msdn.microsoft.com/en-us/library/microsoft.win32.registryview(v=vs.100).aspx) to the code and useRegistry64. It should be safe to use this because of this:Sources:
Wikipedia - WoW64 (Windows 32-bit on Windows 64-bit)
MSDN - RegistryView Enum
@DragonzMaster commented on GitHub (Mar 15, 2016):
@MaxXor - @StingRaptor, You can give this project a look :
[-] https://regexplore.codeplex.com
this project works fine for me (both 32 and 64 bit) and it's very stable , It might help you. 😄
@MaxXor commented on GitHub (Mar 15, 2016):
.... it doesn't need changes as it's compiled for
AnyCPU, ours x86. That's the difference why it's working.@DragonzMaster commented on GitHub (Mar 15, 2016):
So what is preventing us from compiling Quasar client for AnyCPU ??
@MaxXor commented on GitHub (Mar 15, 2016):
The password recovery. (see: https://github.com/quasar/QuasarRAT/issues/352) It was solution 3.
@LjungErik commented on GitHub (Mar 15, 2016):
Thank you for the help, @MaxXor and @DragonzMaster. I have now made the needed changes, and it seems that the RegistryEditor is working and displaying the correct keys in a 64-bit system. 😄
commit:
287101573b@DragonzMaster commented on GitHub (Mar 15, 2016):
Thank you for your efforts, @StingRaptor .I've tested the client from your fork and it seems to be fixed. The project which I mentioned before can help you to get Default values and allow you to search the registry.
EDIT : The registry form is too big, its size need to be fixed and reduced beside the the forms title need to be changed and add user@pc and IP like other forms (remote desktop, file manager, etc ....)
also we need to be able to edit the value by double clicking on it.
@MaxXor commented on GitHub (Mar 15, 2016):
@StingRaptor Yes please adjust the form.
@LjungErik commented on GitHub (Mar 15, 2016):
@DragonzMaster @MaxXor Ok, this is a quick fix. However what is a reasonable size? 800x600?
@MaxXor commented on GitHub (Mar 15, 2016):
Yes.
@LjungErik commented on GitHub (Mar 15, 2016):
@DragonzMaster I will look at the link you provided when I have more time on my hands, Thank you. 😄
Title and form size fixed in:
6492b2734d