mirror of
https://github.com/quasar/Quasar.git
synced 2026-04-25 15:25:59 +03:00
[GH-ISSUE #52] Server crash when trying to build a Client without Client.bin #17
Labels
No labels
bug
bug
cant-reproduce
discussion
duplicate
easy
enhancement
help wanted
improvement
invalid
need more info
pull-request
question
wont-add
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Quasar#17
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yankejustin on GitHub (Apr 9, 2015).
Original GitHub issue: https://github.com/quasar/Quasar/issues/52
Reproducing:
Why?:
The top of the 'Build' method (that builds the Client) loads the Client's built .bin file into a variable, but fails to take into account the chance that it is not there or is unusable.
I have marked this as an issue because, while it is something the server can't do much about (we need that .bin file!), the server should not crash just for trying to build a Client.
Where?:
https://github.com/MaxXor/xRAT/tree/master/Server/Core/Build/ClientBuilder.cs#L15
Solution:
I just wanted to bring this to your attention and let you handle it. To solve this issue, just enclose the variable in its own try-catch. That way, it will still fail, but we will not crash and burn. :)
Note: I personally suggest it has its own try-catch block so that you can give a special Exception message that states something like: "Unable to load the Client Assembly Information. Please re-build the Client."
@MaxXor commented on GitHub (Apr 9, 2015):
Thanks!