[GH-ISSUE #251] Port number data type #118

New issue

Closed

opened 2026-02-27 15:48:54 +03:00 by kerem · 5 comments

kerem commented

2026-02-27 15:48:54 +03:00

Owner

Originally created by @yankejustin on GitHub (Jun 1, 2015).
Original GitHub issue: https://github.com/quasar/Quasar/issues/251

Change Requested:

The port number is currently stored as an int. While we currently parse the text from the Settings Form as a ushort, the data type used to store the port number is an int.

Originally created by @yankejustin on GitHub (Jun 1, 2015). Original GitHub issue: https://github.com/quasar/Quasar/issues/251 <h1>Change Requested:</h1> The port number is currently stored as an <code>int</code>. While we currently parse the text from the Settings Form as a <code>ushort</code>, the data type used to store the port number is an <code>int</code>.

kerem

2026-02-27 15:48:54 +03:00

closed this issue
added the
invalid
label

kerem commented

2026-02-27 15:48:55 +03:00

Author

Owner

@MaxXor commented on GitHub (Jun 1, 2015):

huh? The client and server stores the Port as ushort already??
https://github.com/MaxXor/xRAT/blob/master/Server/Core/Server.cs#L15
https://github.com/MaxXor/xRAT/blob/master/Client/Config/Settings.cs#L14

The Settings Form parses the Port also as ushort.

@MaxXor commented on GitHub (Jun 1, 2015): huh? The client and server stores the Port as `ushort` already?? https://github.com/MaxXor/xRAT/blob/master/Server/Core/Server.cs#L15 https://github.com/MaxXor/xRAT/blob/master/Client/Config/Settings.cs#L14 The Settings Form parses the Port also as `ushort`.

kerem commented

2026-02-27 15:48:55 +03:00

Author

Owner

@yankejustin commented on GitHub (Jun 1, 2015):

I apologize. I misread.

@yankejustin commented on GitHub (Jun 1, 2015): I apologize. I misread.

kerem commented

2026-02-27 15:48:55 +03:00

Author

Owner

@ghost commented on GitHub (Jun 5, 2015):

@MaxXor part of this proposed change would allow the port number to be configurable, allowing you to recover if you lost your VPN service. The other part would allow for at least one fallback DNS entry for the host, allowing you to recover if you lost your DNS service. I find both of these to be very valuable features.

@ghost commented on GitHub (Jun 5, 2015): @MaxXor part of this proposed change would allow the port number to be configurable, allowing you to recover if you lost your VPN service. The other part would allow for at least one fallback DNS entry for the host, allowing you to recover if you lost your DNS service. I find both of these to be very valuable features.

kerem commented

2026-02-27 15:48:55 +03:00

Author

Owner

@yankejustin commented on GitHub (Jun 5, 2015):

@DavesPlanet You may have misunderstood my purpose for opening this issue:
I had misread the data type for the port, mistaking the ushort it correctly uses and instead thought it was an int. There was no issue besides my prior misunderstanding of what is currently correctly used. :)

@yankejustin commented on GitHub (Jun 5, 2015): @DavesPlanet You may have misunderstood my purpose for opening this issue: I had misread the data type for the port, mistaking the <code>ushort</code> it correctly uses and instead thought it was an <code>int</code>. There was no issue besides my prior misunderstanding of what is currently <i>correctly</i> used. :)

kerem commented

2026-02-27 15:48:55 +03:00

Author

Owner

@ghost commented on GitHub (Jun 16, 2015):

@yankejustin actually I'm just too stoopid to realize this was a discussion of a bug report and not of the pull request. Sorry for my ignorance.

@ghost commented on GitHub (Jun 16, 2015): @yankejustin actually I'm just too stoopid to realize this was a discussion of a bug report and not of the pull request. Sorry for my ignorance.