[PR #427] [MERGED] Fix bug with RegistryEditor not working in Release build #1136

New issue

Closed

opened 2026-02-27 15:53:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:53:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/427
Author: @LjungErik
Created: 3/15/2016
Status: ✅ Merged
Merged: 3/17/2016
Merged by: @MaxXor

Base: master ← Head: master

📝 Commits (10+)

c47aa5f Fix error handling of registry key delete
44575b9 Changed threading of registrySeeker and refactor code
f4378ae Removed unnecessary functions from RegValueData.cs
5e3e097 Changed RegSeekerMatch.cs to use an Array instead of a List
fd202b3 Removed unused using of xServer.Core.Extensions
f14f38b Added Registry namespace as a exception to Renamer
8c5ace8 Changed error messages to better state the cause
a1f4f19 Refactored parts of the modified code.
2871015 Fixed bug with RegistryEditor not working correctly in 64-bit systems
6492b27 Added better title for RegistryEditor and corrected its default size

📊 Changes

19 files changed (+222 additions, -454 deletions)

View changed files

📝 Client/Client.csproj (+0 -2)
📝 Client/Core/Commands/CommandHandler.cs (+0 -1)
📝 Client/Core/Commands/RegistryHandler.cs (+16 -26)
📝 Client/Core/Extensions/RegistryKeyExtensions.cs (+1 -45)
📝 Client/Core/Packets/ClientPackets/GetRegistryKeysResponse.cs (+3 -10)
📝 Client/Core/Registry/RegSeekerMatch.cs (+3 -4)
📝 Client/Core/Registry/RegValueData.cs (+1 -12)
📝 Client/Core/Registry/RegistryEditor.cs (+17 -17)
📝 Client/Core/Registry/RegistrySeeker.cs (+84 -191)
➖ Client/Core/Registry/RegistrySeekerParams.cs (+0 -32)
➖ Client/Enums/RegistrySearchAction.cs (+0 -30)
📝 Server/Core/Build/Renamer.cs (+2 -1)
📝 Server/Core/Commands/RegistryHandler.cs (+19 -9)
📝 Server/Core/Packets/ClientPackets/GetRegistryKeysResponse.cs (+3 -10)
📝 Server/Core/Registry/RegSeekerMatch.cs (+3 -4)
📝 Server/Core/Registry/RegValueData.cs (+1 -12)
📝 Server/Forms/FrmRegistryEditor.Designer.cs (+12 -12)
📝 Server/Forms/FrmRegistryEditor.cs (+55 -34)
📝 Server/Forms/FrmRegistryEditor.resx (+2 -2)

📄 Description

This pull requests contains a fix to the RegistryEditor not working in Release (issue:#425, #426), and also a fix to a delete bug for registry keys. Besides this some refactoring of the code has been made to make it more readable.

Changes made:

Added Registry namespace as an exception in Renamer.cs (Prevent obfuscation).
Removed BackgroundWorker from RegistryEditor
Added threading to RegistryHandler
Changed RegSeekerMatch.cs to use Arrays for RegValueData instead of a List
Activate exceptions for registry key delete operation to correctly signals when a key cannot be deleted

Edit:

Fixed issue with RegistryEditor not working probably on 64-bit systems
Corrected the title of the form to display as "RegistryEditor - user@pc [IP:PORT]"
Corrected the size of the form to 800x600

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/427 **Author:** [@LjungErik](https://github.com/LjungErik) **Created:** 3/15/2016 **Status:** ✅ Merged **Merged:** 3/17/2016 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`c47aa5f`](https://github.com/quasar/Quasar/commit/c47aa5fa0bb8b62f99b4c028537ec376f19b0354) Fix error handling of registry key delete - [`44575b9`](https://github.com/quasar/Quasar/commit/44575b95d118b5b89a2d6c3f345b0924546c3a66) Changed threading of registrySeeker and refactor code - [`f4378ae`](https://github.com/quasar/Quasar/commit/f4378ae56e6eb4d2895dcc41863b7838d42a241f) Removed unnecessary functions from RegValueData.cs - [`5e3e097`](https://github.com/quasar/Quasar/commit/5e3e097edb8800f3023b714739c30081a1def317) Changed RegSeekerMatch.cs to use an Array instead of a List - [`fd202b3`](https://github.com/quasar/Quasar/commit/fd202b30cfbf7e3ae5b63ac587a5f5df8fdc87a7) Removed unused using of xServer.Core.Extensions - [`f14f38b`](https://github.com/quasar/Quasar/commit/f14f38b0dea62951ce3f524c8deae5efa37267db) Added Registry namespace as a exception to Renamer - [`8c5ace8`](https://github.com/quasar/Quasar/commit/8c5ace81969a388e40d69c080096cae09caee95d) Changed error messages to better state the cause - [`a1f4f19`](https://github.com/quasar/Quasar/commit/a1f4f192caaa1e0982f1f2d2c81a7762bb42039d) Refactored parts of the modified code. - [`2871015`](https://github.com/quasar/Quasar/commit/287101573b8fa5f43706e74d8af6200c4a902d79) Fixed bug with RegistryEditor not working correctly in 64-bit systems - [`6492b27`](https://github.com/quasar/Quasar/commit/6492b2734d533690d7c93b312e904d79e642e401) Added better title for RegistryEditor and corrected its default size ### 📊 Changes **19 files changed** (+222 additions, -454 deletions) <details> <summary>View changed files</summary> 📝 `Client/Client.csproj` (+0 -2) 📝 `Client/Core/Commands/CommandHandler.cs` (+0 -1) 📝 `Client/Core/Commands/RegistryHandler.cs` (+16 -26) 📝 `Client/Core/Extensions/RegistryKeyExtensions.cs` (+1 -45) 📝 `Client/Core/Packets/ClientPackets/GetRegistryKeysResponse.cs` (+3 -10) 📝 `Client/Core/Registry/RegSeekerMatch.cs` (+3 -4) 📝 `Client/Core/Registry/RegValueData.cs` (+1 -12) 📝 `Client/Core/Registry/RegistryEditor.cs` (+17 -17) 📝 `Client/Core/Registry/RegistrySeeker.cs` (+84 -191) ➖ `Client/Core/Registry/RegistrySeekerParams.cs` (+0 -32) ➖ `Client/Enums/RegistrySearchAction.cs` (+0 -30) 📝 `Server/Core/Build/Renamer.cs` (+2 -1) 📝 `Server/Core/Commands/RegistryHandler.cs` (+19 -9) 📝 `Server/Core/Packets/ClientPackets/GetRegistryKeysResponse.cs` (+3 -10) 📝 `Server/Core/Registry/RegSeekerMatch.cs` (+3 -4) 📝 `Server/Core/Registry/RegValueData.cs` (+1 -12) 📝 `Server/Forms/FrmRegistryEditor.Designer.cs` (+12 -12) 📝 `Server/Forms/FrmRegistryEditor.cs` (+55 -34) 📝 `Server/Forms/FrmRegistryEditor.resx` (+2 -2) </details> ### 📄 Description This pull requests contains a fix to the `RegistryEditor` not working in Release (issue:#425, #426), and also a fix to a delete bug for registry keys. Besides this some refactoring of the code has been made to make it more readable. **Changes made:** - Added Registry namespace as an exception in Renamer.cs (Prevent obfuscation). - Removed BackgroundWorker from RegistryEditor - Added threading to RegistryHandler - Changed RegSeekerMatch.cs to use Arrays for RegValueData instead of a List - Activate exceptions for registry key delete operation to correctly signals when a key cannot be deleted Edit: - Fixed issue with `RegistryEditor` not working probably on 64-bit systems - Corrected the title of the form to display as "RegistryEditor - user@pc [IP:PORT]" - Corrected the size of the form to 800x600 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>