[PR #353] [CLOSED] Reliability and Behavior Improvements #1116

New issue

Closed

opened 2026-02-27 15:53:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:53:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/353
Author: @yankejustin
Created: 8/25/2015
Status: ❌ Closed

Base: master ← Head: reliability

📝 Commits (3)

f3bf1bb Gracefully handle failed de-serialization
3e201fc Add a few try-catches
dee9223 Make deleting and renaming more responsive

📊 Changes

4 files changed (+70 additions, -32 deletions)

View changed files

📝 Client/Core/Commands/FileHandler.cs (+10 -4)
📝 Client/Core/Commands/SurveillanceHandler.cs (+34 -24)
📝 Client/Core/Networking/Client.cs (+13 -2)
📝 Server/Core/Networking/Client.cs (+13 -2)

📄 Description

Reasoning

Created a new branch for reliability because I intended to fix a larger amount of reliability issues. I was surprised to find that it is still so solid after all the changes in the past month. 💯

Changes

1. Handle an inability to de-serialize a packet in a graceful manner (sets a status message of the situation). - If the server was unable to de-serialize a client's packet, it would crash (depending on the containing data types in the packet) due to an uncaught exception. - If the client was unable to de-serialize a packet from the server, it would crash (depending on the containing data types in the packet) due to an uncaught exception. 2. Added a few more try-catch blocks to some spots in the CommandHandler - Helps to make sure invalid packets from the server won't cause a crash. - Necessary because handlers in the CommandHandler aren't caught. 3. Slightly improved situations when the renaming or deleting of a file or directory failed. - Inform the server via a readable status message. - Always refresh the directory (even if the renaming or deleting of a file or directory failed).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/353 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 8/25/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `reliability` --- ### 📝 Commits (3) - [`f3bf1bb`](https://github.com/quasar/Quasar/commit/f3bf1bbea49b22b3fa068967041a7260b92f513c) Gracefully handle failed de-serialization - [`3e201fc`](https://github.com/quasar/Quasar/commit/3e201fc455021ca438f51cb6aa55b418c76ce267) Add a few try-catches - [`dee9223`](https://github.com/quasar/Quasar/commit/dee9223c01c62f9d8098cae12f8cae1cc92a32c1) Make deleting and renaming more responsive ### 📊 Changes **4 files changed** (+70 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `Client/Core/Commands/FileHandler.cs` (+10 -4) 📝 `Client/Core/Commands/SurveillanceHandler.cs` (+34 -24) 📝 `Client/Core/Networking/Client.cs` (+13 -2) 📝 `Server/Core/Networking/Client.cs` (+13 -2) </details> ### 📄 Description <h1>Reasoning</h1> Created a new branch for reliability because I intended to fix a larger amount of reliability issues. I was surprised to find that it is still so solid after all the changes in the past month. :100: <h1>Changes</h1> 1. Handle an inability to de-serialize a packet in a graceful manner (sets a status message of the situation). - If the server was unable to de-serialize a client's packet, it would crash (depending on the containing data types in the packet) due to an uncaught exception. - If the client was unable to de-serialize a packet from the server, it would crash (depending on the containing data types in the packet) due to an uncaught exception. 2. Added a few more try-catch blocks to some spots in the <code>CommandHandler</code> - Helps to make sure invalid packets from the server won't cause a crash. - Necessary because handlers in the <code>CommandHandler</code> aren't caught. 3. Slightly improved situations when the renaming or deleting of a file or directory failed. - Inform the server via a readable status message. - Always refresh the directory (even if the renaming or deleting of a file or directory failed). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>