mirror of
https://github.com/quasar/Quasar.git
synced 2026-04-26 07:45:57 +03:00
[PR #288] [CLOSED] UPnP fix on FrmMain closing event #1074
Labels
No labels
bug
bug
cant-reproduce
discussion
duplicate
easy
enhancement
help wanted
improvement
invalid
need more info
pull-request
question
wont-add
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Quasar#1074
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/quasar/Quasar/pull/288
Author: @ghost
Created: 7/25/2015
Status: ❌ Closed
Base:
master← Head:master📝 Commits (1)
666c758UPnP fix on FrmMain closing event📊 Changes
1 file changed (+6 additions, -10 deletions)
View changed files
📝
Server/Core/Helper/UPnP.cs(+6 -10)📄 Description
Removed condition for checking
PublicPortproperty. It doesn't appear to be reliable for determining if a port is forwarded or not. Tested this and it had the same behavior when closing the form (Closing slower than normal) and the port was successfully removed from the UPnP list.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.