[PR #288] [CLOSED] UPnP fix on FrmMain closing event #1074

Closed
opened 2026-02-27 15:53:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/288
Author: @ghost
Created: 7/25/2015
Status: Closed

Base: masterHead: master


📝 Commits (1)

  • 666c758 UPnP fix on FrmMain closing event

📊 Changes

1 file changed (+6 additions, -10 deletions)

View changed files

📝 Server/Core/Helper/UPnP.cs (+6 -10)

📄 Description

Removed condition for checking PublicPort property. It doesn't appear to be reliable for determining if a port is forwarded or not. Tested this and it had the same behavior when closing the form (Closing slower than normal) and the port was successfully removed from the UPnP list.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/288 **Author:** [@ghost](https://github.com/ghost) **Created:** 7/25/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`666c758`](https://github.com/quasar/Quasar/commit/666c758951f2f6be852c5acd01d2060d295120f4) UPnP fix on FrmMain closing event ### 📊 Changes **1 file changed** (+6 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `Server/Core/Helper/UPnP.cs` (+6 -10) </details> ### 📄 Description Removed condition for checking `PublicPort` property. It doesn't appear to be reliable for determining if a port is forwarded or not. Tested this and it had the same behavior when closing the form (Closing slower than normal) and the port was successfully removed from the UPnP list. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 15:53:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Quasar#1074
No description provided.