[PR #269] [MERGED] Remote Desktop Fix #1068

New issue

Closed

opened 2026-02-27 15:52:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/269
Author: @yankejustin
Created: 6/20/2015
Status: ✅ Merged
Merged: 6/20/2015
Merged by: @MaxXor

Base: master ← Head: RemoteDesktopFix

📝 Commits (2)

0613e34 Merge pull request #25 from MaxXor/master
615c9db Clone Bitmap on FrmRemoteDesktop

📊 Changes

2 files changed (+11 additions, -4 deletions)

View changed files

📝 Server/Core/Commands/SurveillanceHandler.cs (+2 -2)
📝 Server/Forms/FrmRemoteDesktop.cs (+9 -2)

📄 Description

Issue

The Remote Desktop feature was having issues. When I tried using the feature, it only gave me a black screen for both of my monitors. I noticed that, when the Form was closed and re-opened, it also gave me no monitors to use.

Changes

I have added an additional parameter to the Remote Desktop Form's UpdateImage method. This new parameter is optional (defaulted to false). This parameter is used to decide if the Bitmap provided in the first parameter should be cloned or not.

Reasoning

It should be the responsibility of the Remote Desktop Form's UpdateImage to decide whether it should clone the Bitmap anyways. This fix works because it places the cloning and the casting to a Bitmap back in a try-catch block as it was before.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/269 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 6/20/2015 **Status:** ✅ Merged **Merged:** 6/20/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `RemoteDesktopFix` --- ### 📝 Commits (2) - [`0613e34`](https://github.com/quasar/Quasar/commit/0613e34325bda5100eb0cf890aabab578bef9c09) Merge pull request #25 from MaxXor/master - [`615c9db`](https://github.com/quasar/Quasar/commit/615c9dbcc352a862cea50c23ec08e1d3abe075e9) Clone Bitmap on FrmRemoteDesktop ### 📊 Changes **2 files changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Server/Core/Commands/SurveillanceHandler.cs` (+2 -2) 📝 `Server/Forms/FrmRemoteDesktop.cs` (+9 -2) </details> ### 📄 Description <h1>Issue</h1> The Remote Desktop feature was having issues. When I tried using the feature, it only gave me a black screen for both of my monitors. I noticed that, when the Form was closed and re-opened, it also gave me no monitors to use. <h1>Changes</h1> I have added an additional parameter to the Remote Desktop Form's <code>UpdateImage</code> method. This new parameter is optional (defaulted to <code>false</code>). This parameter is used to decide if the Bitmap provided in the first parameter should be cloned or not. <h1>Reasoning</h1> It should be the responsibility of the Remote Desktop Form's <code>UpdateImage</code> to decide whether it should clone the Bitmap anyways. This fix works because it places the cloning and the casting to a Bitmap back in a try-catch block as it was before. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>