[PR #259] [MERGED] Better server validation #1065

New issue

Closed

opened 2026-02-27 15:52:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/259
Author: @yankejustin
Created: 6/2/2015
Status: ✅ Merged
Merged: 6/3/2015
Merged by: @MaxXor

Base: master ← Head: ClientInputSafety

📝 Commits (4)

a4defce SystemHandler validation
bf5b517 SurveillanceHandler validation
81c9b23 MiscHandler validation
2d08378 Moved validation a bit higher

📊 Changes

3 files changed (+20 additions, -4 deletions)

View changed files

📝 Server/Core/Commands/MiscHandler.cs (+4 -1)
📝 Server/Core/Commands/SurveillanceHandler.cs (+10 -0)
📝 Server/Core/Commands/SystemHandler.cs (+6 -3)

📄 Description

Reason

A client should never have the ability to break the server (cause an uncaught exception) by sending packets with invalid or otherwise unusable data.

Changes

- Added more restrictive validation to ensure usable information by the received packets on the handlers before use. This makes sure that a client that may make a strange request with bad data without causing a server crash.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/259 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 6/2/2015 **Status:** ✅ Merged **Merged:** 6/3/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `ClientInputSafety` --- ### 📝 Commits (4) - [`a4defce`](https://github.com/quasar/Quasar/commit/a4defce5686764561017167f0844de1f1e2f5f95) SystemHandler validation - [`bf5b517`](https://github.com/quasar/Quasar/commit/bf5b517ecaf9eba5a352ccf965e69854119216b3) SurveillanceHandler validation - [`81c9b23`](https://github.com/quasar/Quasar/commit/81c9b238c8e1d3c383404a5031c30b64167be7ef) MiscHandler validation - [`2d08378`](https://github.com/quasar/Quasar/commit/2d083782fcb3330e3f7d111aa663b79499e0d998) Moved validation a bit higher ### 📊 Changes **3 files changed** (+20 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Server/Core/Commands/MiscHandler.cs` (+4 -1) 📝 `Server/Core/Commands/SurveillanceHandler.cs` (+10 -0) 📝 `Server/Core/Commands/SystemHandler.cs` (+6 -3) </details> ### 📄 Description <h1>Reason</h1> A client should <b>never</b> have the ability to break the server (cause an uncaught exception) by sending packets with invalid or otherwise unusable data. <h1>Changes</h1> - Added more restrictive validation to ensure usable information by the received packets on the handlers before use. This makes sure that a client that may make a strange request with bad data without causing a server crash. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>