mirror of
https://github.com/quasar/Quasar.git
synced 2026-04-26 07:45:57 +03:00
[PR #252] [CLOSED] changed reconnect from milliseconds to seconds, improved reconnect attempt #1062
Labels
No labels
bug
bug
cant-reproduce
discussion
duplicate
easy
enhancement
help wanted
improvement
invalid
need more info
pull-request
question
wont-add
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Quasar#1062
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/quasar/Quasar/pull/252
Author: @ghost
Created: 6/1/2015
Status: ❌ Closed
Base:
master← Head:seconds📝 Commits (1)
3c27b4achanged reconnect delay from milliseconds to seconds, improved randomness in reconnect attempt📊 Changes
3 files changed (+17 additions, -14 deletions)
View changed files
📝
Client/Config/Settings.cs(+2 -2)📝
Client/Program.cs(+4 -1)📝
Server/Forms/FrmBuilder.Designer.cs(+11 -11)📄 Description
I changed the reconnect delay from milliseconds to seconds. The builder form label changed to "seconds" and the client now multiplies the reconnect delay by 1000 to convert it to milliseconds. I modified the defaults for debug to be 1 second and for production to be 300 seconds, or 5 minutes. The previous value of 5 seconds created a much too obvious rapidly polling outgoing connection.
Additionally I modified the randomness in the reconnect timeout to always be between 50% and 150% of the configured value, allowing for a better randomly staggered reconnect time that is less likely to show up as a simple recurring pattern. If you use the 5 minute default that I set then the retry time will be between 2.5 minutes and 7.5 minutes.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.