[PR #221] [CLOSED] #220 fix #1052

Closed
opened 2026-02-27 15:52:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/221
Author: @ghost
Created: 5/27/2015
Status: Closed

Base: masterHead: dev


📝 Commits (3)

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 Client/Core/Helper/Helper.cs (+5 -1)
📝 Server/Core/Server.cs (+1 -5)

📄 Description

we are calling to remove the client from the list twice in this class.

Once in the OnClientState method, and once when stopping the listen server. I'm not sure we need to call Disconnect in the OnClientState method but this I will leave this fix up for now


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/221 **Author:** [@ghost](https://github.com/ghost) **Created:** 5/27/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dev` --- ### 📝 Commits (3) - [`33dfcee`](https://github.com/quasar/Quasar/commit/33dfceeb80dc6d1db552dba2bc28c89e05c931a1) #220 fix - [`50741e8`](https://github.com/quasar/Quasar/commit/50741e810452300dc0239ef4b2d33fddb8901d9b) edit - [`4b590e9`](https://github.com/quasar/Quasar/commit/4b590e9fe3ebedaf02dca06621afb1fcc5194f9a) #225 fix ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Client/Core/Helper/Helper.cs` (+5 -1) 📝 `Server/Core/Server.cs` (+1 -5) </details> ### 📄 Description we are calling to remove the client from the list twice in this class. Once in the OnClientState method, and once when stopping the listen server. I'm not sure we need to call Disconnect in the OnClientState method but this I will leave this fix up for now --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 15:52:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Quasar#1052
No description provided.