[PR #213] [CLOSED] small behavior fix #1049

New issue

Closed

opened 2026-02-27 15:52:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/213
Author: @ghost
Created: 5/26/2015
Status: ❌ Closed

Base: master ← Head: dev

📝 Commits (1)

a2fb891 small behavior fix

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Server/Forms/FrmMain.cs (+1 -1)

📄 Description

only try to remove upnp settings if the server is listening, if you have this checked, closing the form will stall for a second or two even if the server is not listening. It stalls for a second or two because we are forwarding the port when we start the server, not when we open the form, so if i start the server form without starting the listen server and I have UPnP enabled, it will try to remove a port that hasn't been forwarded and it takes a while for the UPnP class to process this causing the form to hang

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/213 **Author:** [@ghost](https://github.com/ghost) **Created:** 5/26/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dev` --- ### 📝 Commits (1) - [`a2fb891`](https://github.com/quasar/Quasar/commit/a2fb891e97ba9330f8e1e53ed40075f0d22449cb) small behavior fix ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Server/Forms/FrmMain.cs` (+1 -1) </details> ### 📄 Description only try to remove upnp settings if the server is listening, if you have this checked, closing the form will stall for a second or two even if the server is not listening. It stalls for a second or two because we are forwarding the port when we start the server, not when we open the form, so if i start the server form without starting the listen server and I have UPnP enabled, it will try to remove a port that hasn't been forwarded and it takes a while for the UPnP class to process this causing the form to hang --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>