[PR #198] [MERGED] #194 fix #1042

New issue

Closed

opened 2026-02-27 15:52:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/198
Author: @ghost
Created: 5/25/2015
Status: ✅ Merged
Merged: 5/25/2015
Merged by: @MaxXor

Base: master ← Head: master

📝 Commits (1)

49c6a0a #194 fix

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Client/Core/Keylogger/Logger.cs (+1 -1)

📄 Description

Bear in mind this does not fix the Alt Gr keypresses. Pressing this key will still produce the same symbols/behaviors when the keylogger is not enabled.

What this fix does: we are receiving the character value for a KeyPress and we are handling it by ignoring it if any modifier keys are set. In this case "Ctrl + Alt" which I will be trying to accomplish in a later fix (if I can figure out how to do this).

For example, a user with a german keyboard layout presses (Ctrl + alt + 2), which is the same as AltGr + 2, the call to our PressedKeys list will do the following

-check if key modifiers are set
-check if the list contains a key with a character value that is comparable to a key

If the key is a normal character, for example user presses (Ctrl + Alt + k) on a german keyboard layout, the result would be true and the method would return, ignoring appending the character 'k' to the log

If the key is not a normal character that is comparable to the value of a Key, our call will fall through to the next call, and add the character that is returned. For example, user presses (Ctrl + Alt + 2) to produce the special character, the Keys enum values won't contain a key with that symbol and our list won't either so it will fall through and print the special character

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/198 **Author:** [@ghost](https://github.com/ghost) **Created:** 5/25/2015 **Status:** ✅ Merged **Merged:** 5/25/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`49c6a0a`](https://github.com/quasar/Quasar/commit/49c6a0a58a38ce5e4b3f7783e51af42ab82d61a2) #194 fix ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Client/Core/Keylogger/Logger.cs` (+1 -1) </details> ### 📄 Description Bear in mind this does not fix the Alt Gr keypresses. Pressing this key will still produce the same symbols/behaviors when the keylogger is not enabled. What this fix does: we are receiving the character value for a KeyPress and we are handling it by ignoring it if any modifier keys are set. In this case "Ctrl + Alt" which I will be trying to accomplish in a later fix (if I can figure out how to do this). For example, a user with a german keyboard layout presses (Ctrl + alt + 2), which is the same as AltGr + 2, the call to our PressedKeys list will do the following -check if key modifiers are set -check if the list contains a key with a character value that is comparable to a key If the key is a normal character, for example user presses (Ctrl + Alt + k) on a german keyboard layout, the result would be true and the method would return, ignoring appending the character 'k' to the log If the key is not a normal character that is comparable to the value of a Key, our call will fall through to the next call, and add the character that is returned. For example, user presses (Ctrl + Alt + 2) to produce the special character, the Keys enum values won't contain a key with that symbol and our list won't either so it will fall through and print the special character --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>