[PR #191] [MERGED] Improvements #1038

New issue

Closed

opened 2026-02-27 15:52:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/191
Author: @yankejustin
Created: 5/25/2015
Status: ✅ Merged
Merged: 5/25/2015
Merged by: @MaxXor

Base: master ← Head: Improvements

📝 Commits (2)

f5d671d Removed some repetitive code
94e5064 Detecting illegal characters efficiently

📊 Changes

1 file changed (+23 additions, -25 deletions)

View changed files

📝 Server/Forms/FrmBuilder.cs (+23 -25)

📄 Description

Changes for the FrmBuilder Form's code

1. Removed some repetitive code by placing in a method. 2. Using LINQ, efficiently compute a mathematical union for the two char arrays and use that to test against detection of illegal characters. Much more efficient and no more wasted time casting. :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/191 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 5/25/2015 **Status:** ✅ Merged **Merged:** 5/25/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `Improvements` --- ### 📝 Commits (2) - [`f5d671d`](https://github.com/quasar/Quasar/commit/f5d671d93a91894c7a85b1cfa3b9081a6d462b6f) Removed some repetitive code - [`94e5064`](https://github.com/quasar/Quasar/commit/94e50641cbba148a4a2c8e55280020b98f993484) Detecting illegal characters efficiently ### 📊 Changes **1 file changed** (+23 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `Server/Forms/FrmBuilder.cs` (+23 -25) </details> ### 📄 Description <h1>Changes for the FrmBuilder Form's code</h1> 1. Removed some repetitive code by placing in a method. 2. Using LINQ, efficiently compute a mathematical union for the two char arrays and use that to test against detection of illegal characters. Much more efficient and no more wasted time casting. :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>