[PR #190] [CLOSED] Keylogger fixes #1036

New issue

Closed

opened 2026-02-27 15:52:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/190
Author: @ghost
Created: 5/24/2015
Status: ❌ Closed

Base: dev ← Head: dev

📝 Commits (6)

42e67b7 in the Logger.cs file what this fixes:
cf02b09 Revert "in the Logger.cs file what this fixes:"
6c0e063 Modifier keys + key press fix
e55818c Revert "Revert "in the Logger.cs file what this fixes:""
d51f1b4 ToUnicodeEx buffer fix
9d43efc ToUnicodeEx Buffer fix #2

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 Client/Core/Keylogger/Logger.cs (+1 -1)
📝 Client/Core/Keylogger/WinApi/KeyboardNativeMethods.cs (+4 -2)

📄 Description

(Please ignore the reverts, I've just installed Visual studio 2013 on my host and noticed it has a github feature pretty neat!)

in the Logger.cs file what this fixes:
-if any modifier keys are down and a character is pressed on the
keyboard, it will look for a Key from the key character, if it doesn't
find it, it will process the character normally. This is as best as I
could do for Alt Gr because Alt Gr translates to (LControlKey |
ControlKey). In order to get Alt Gr presses to work, normally you would
have to press (Ctrl + Alt + key) to write the characters such as the
ones here highlighted in blue:
http://en.wikipedia.org/wiki/German_keyboard_layout#/media/File:KB_Germany.svg

This introduced a bug into the KeyboardNativeMethods class,
IndexOutOfBoundsException. The buffer from ToUnicodeEx was returning a
an index of zero. ?????? (this is a bug in the operating system). I tested this by pressing
(Ctrl + alt + all keys on my keyboard, specifically Ctrl + alt + [ and
Ctrl + alt + numpad return key that were causing the crashes)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/190 **Author:** [@ghost](https://github.com/ghost) **Created:** 5/24/2015 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (6) - [`42e67b7`](https://github.com/quasar/Quasar/commit/42e67b731f4eb3531967925eddb4b1adb01ded89) in the Logger.cs file what this fixes: - [`cf02b09`](https://github.com/quasar/Quasar/commit/cf02b09e5e62633fc6ac9752ad302a110162dfa0) Revert "in the Logger.cs file what this fixes:" - [`6c0e063`](https://github.com/quasar/Quasar/commit/6c0e06385645a240279d50aa7d3dc0c527e4fac7) Modifier keys + key press fix - [`e55818c`](https://github.com/quasar/Quasar/commit/e55818c4efd30614324ac1615c7b30cf99e8e2be) Revert "Revert "in the Logger.cs file what this fixes:"" - [`d51f1b4`](https://github.com/quasar/Quasar/commit/d51f1b48a6b5671a6c869810058c58708573acd1) ToUnicodeEx buffer fix - [`9d43efc`](https://github.com/quasar/Quasar/commit/9d43efc875aa18175438901abdec8defd1b66dc1) ToUnicodeEx Buffer fix #2 ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Client/Core/Keylogger/Logger.cs` (+1 -1) 📝 `Client/Core/Keylogger/WinApi/KeyboardNativeMethods.cs` (+4 -2) </details> ### 📄 Description (Please ignore the reverts, I've just installed Visual studio 2013 on my host and noticed it has a github feature pretty neat!) in the Logger.cs file what this fixes: -if any modifier keys are down and a character is pressed on the keyboard, it will look for a Key from the key character, if it doesn't find it, it will process the character normally. This is as best as I could do for Alt Gr because Alt Gr translates to (LControlKey | ControlKey). In order to get Alt Gr presses to work, normally you would have to press (Ctrl + Alt + key) to write the characters such as the ones here highlighted in blue: http://en.wikipedia.org/wiki/German_keyboard_layout#/media/File:KB_Germany.svg This introduced a bug into the KeyboardNativeMethods class, IndexOutOfBoundsException. The buffer from ToUnicodeEx was returning a an index of zero. ?????? (this is a bug in the operating system). I tested this by pressing (Ctrl + alt + all keys on my keyboard, specifically Ctrl + alt + [ and Ctrl + alt + numpad return key that were causing the crashes) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>