[PR #161] [MERGED] Improvements #1015

New issue

Closed

opened 2026-02-27 15:52:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/161
Author: @yankejustin
Created: 5/21/2015
Status: ✅ Merged
Merged: 5/21/2015
Merged by: @MaxXor

Base: master ← Head: Improvements

📝 Commits (8)

d022e55 Slight performance boost
8b20dee More meaningful exceptions
2126127 Moved string array to class-level
d100c47 More meaningful exception for Client Helper
8cbab66 Forgot to initialize const string array
9e17537 Must use static readonly instead of const
de3db66 Significant memory leak reduction
792a9fc Don't dispose bmpRes

📊 Changes

6 files changed (+80 additions, -61 deletions)

View changed files

📝 Client/Core/Client.cs (+3 -0)
📝 Client/Core/Helper/FileSplit.cs (+27 -8)
📝 Client/Core/Helper/Helper.cs (+20 -45)
📝 Server/Core/Client.cs (+3 -0)
📝 Server/Core/Helper/FileSplit.cs (+26 -7)
📝 Server/Core/Helper/Helper.cs (+1 -1)

📄 Description

Exceptions

- Exceptions provide better responses for the server (providing more-accurate status updates). It also makes debugging a bit easier - Add types to serializer faster. When a matching subtype's derived type is found, break out of the loop.

Performance

- Big reduction on memory consumption when using Remote Desktop (for Client). - Faster retrieval of file size.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/161 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 5/21/2015 **Status:** ✅ Merged **Merged:** 5/21/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `Improvements` --- ### 📝 Commits (8) - [`d022e55`](https://github.com/quasar/Quasar/commit/d022e55cc791e01644f8c812400a049a959d79e4) Slight performance boost - [`8b20dee`](https://github.com/quasar/Quasar/commit/8b20dee5e1701b9a9dd37473a31c1da5bf0a68e4) More meaningful exceptions - [`2126127`](https://github.com/quasar/Quasar/commit/21261270d8165412b3f173f7e9ed26a4e2661ab9) Moved string array to class-level - [`d100c47`](https://github.com/quasar/Quasar/commit/d100c470912dc12e8664ad66a20689ff0cb25350) More meaningful exception for Client Helper - [`8cbab66`](https://github.com/quasar/Quasar/commit/8cbab66bf8a8493fb90e33aa95651a5c4f91c9af) Forgot to initialize const string array - [`9e17537`](https://github.com/quasar/Quasar/commit/9e175378fc3ed8f59bedc0bdfc6d6e9fbae9d23c) Must use static readonly instead of const - [`de3db66`](https://github.com/quasar/Quasar/commit/de3db663e923ff783ed14d4c1573c863884cbffa) Significant memory leak reduction - [`792a9fc`](https://github.com/quasar/Quasar/commit/792a9fc83f9c35f8cd24021845c85f078ddf6548) Don't dispose bmpRes ### 📊 Changes **6 files changed** (+80 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `Client/Core/Client.cs` (+3 -0) 📝 `Client/Core/Helper/FileSplit.cs` (+27 -8) 📝 `Client/Core/Helper/Helper.cs` (+20 -45) 📝 `Server/Core/Client.cs` (+3 -0) 📝 `Server/Core/Helper/FileSplit.cs` (+26 -7) 📝 `Server/Core/Helper/Helper.cs` (+1 -1) </details> ### 📄 Description <h1>Exceptions</h1> - Exceptions provide better responses for the server (providing more-accurate status updates). It also makes debugging a bit easier - Add types to serializer faster. When a matching subtype's derived type is found, break out of the loop. <h1>Performance</h1> - <b>Big</b> reduction on memory consumption when using Remote Desktop (for Client). - Faster retrieval of file size. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>