[PR #155] [MERGED] Fixes for uninstall issues #1010

New issue

Closed

opened 2026-02-27 15:52:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/155
Author: @yankejustin
Created: 5/20/2015
Status: ✅ Merged
Merged: 5/20/2015
Merged by: @MaxXor

Base: master ← Head: Fix

📝 Commits (2)

a3faf0c Merge pull request #6 from MaxXor/master
ce61f3d Possible fix

📊 Changes

1 file changed (+8 additions, -1 deletions)

View changed files

📝 Client/Core/RemoteShell/Shell.cs (+8 -1)

📄 Description

Should fix second issue of https://github.com/MaxXor/xRAT/issues/153

Brief Explanation

Process.Kill() can throw quite a few different exceptions. While checking if the process has exited makes it slightly safer, exceptions can still be thrown for many other reasons (perhaps the process is already terminating, or a process can not be terminated).
The point of it should be: Make sure the process is not null. If it has not exited yet, try to kill it. If it can't be killed, do not worry anymore and simply dispose of it because it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/155 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 5/20/2015 **Status:** ✅ Merged **Merged:** 5/20/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `Fix` --- ### 📝 Commits (2) - [`a3faf0c`](https://github.com/quasar/Quasar/commit/a3faf0c84ed4df39fe314ed1a6dee2a380aca906) Merge pull request #6 from MaxXor/master - [`ce61f3d`](https://github.com/quasar/Quasar/commit/ce61f3dcfe432af155187308982a534c21988c91) Possible fix ### 📊 Changes **1 file changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Client/Core/RemoteShell/Shell.cs` (+8 -1) </details> ### 📄 Description Should fix second issue of https://github.com/MaxXor/xRAT/issues/153 <hr /> <h2>Brief Explanation</h2> <code>Process.Kill()</code> can throw quite a few different exceptions. While checking if the process has exited makes it slightly safer, exceptions can still be thrown for many other reasons (perhaps the process is already terminating, or a process can not be terminated). The point of it should be: Make sure the process is not null. If it has not exited yet, try to kill it. If it can't be killed, do not worry anymore and simply dispose of it because it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>