mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 00:25:56 +03:00
[GH-ISSUE #939] Feature request: Add buttons to toolbar for quickly disabling/enabling breakpoints, map remote, map local and network conditions #933
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#933
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cameroncooke on GitHub (Jul 15, 2021).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/939
Originally assigned to: @NghiaTranUIT on GitHub.
Would be useful to have easy to access buttons to globally enable and disable:
Quick often I want to disable and enable breakpoints many times in testing and at the moment it's 4 clicks to do so. On Charles, it's a single click on the breakpoints toolbar icon.
It would be useful to be able to do this for all other features that have a global on/off switch.
While you can turn off some features from the status bar it's still two clicks and you can't turn on that feature from there. Be able to toggle quickly would be really handy.
These buttons wouldn't present the configuration interface they would just enable and disable the entire feature based on current rules and configurations.
Proxyman version? (Ex. Proxyman 1.4.3)
2.29.0 (22900)
macOS Version? (Ex. mac 10.14)
12.0 Beta (21A5284e)
Steps to reproduce
Expected behavior
Screenshots (optional)
@NghiaTranUIT commented on GitHub (Jul 15, 2021):
Thanks for your valuable insight from the Charles 👍
Instead of putting these toggles on the status bar (4 toggle buttons), which might make the app is too more complicated, I think that we can:
For instance, OPT+CMD+B will open the Breakpoint window. SHIFT+CMD+B will toggle the feature (ON/OFF).
OPT+CMD+L will open the Map Local Window => SHIFT+CMD+L to toggle the feature.
You can workaround by click on the Tool Badge on the Bottom Bar. The tool window will show up. Then, you can click to disable a tool. Sorry again, there is no shortcut at the moment. We will add it 😿
@cameroncooke commented on GitHub (Jul 15, 2021):
I have a terrible memory for shortcut keys so by all means add them but I wouldn't use them. I do better with icons so if there were buttons on the main toolbar and/or the ProxyMan menu bar that would be great.
@NghiaTranUIT commented on GitHub (Jul 15, 2021):
Yes, it's a trade-off. Most people don't remember a shortcut.
I suppose that I can support "Customize ToolBar" as the Finder app does 😄
I will implement this feature, and you can drag the tool button you like on the status bar as you need 👍
By doing this way, it doesn't mess up the UI in general and can serve you better 👍
@cameroncooke commented on GitHub (Jul 15, 2021):
Excellent, that was the first thing I looked for, I was right-clicking the toolbar like a crazy person! haha
@robmathers commented on GitHub (Jul 16, 2021):
I'll just add my +1 for a customizable toolbar with more options. It makes sense that the default configuration would be simpler, but adding more options to it would be great, as well as good practice for a Mac app!
@NghiaTranUIT commented on GitHub (Jul 17, 2021):
Thanks @robmathers. I'm working on this feature and soon sent you guys a Beta build 😄
@NghiaTranUIT commented on GitHub (Aug 27, 2021):
Hey @cameroncooke @robmathers @sleeve if you guys don't mind, please try this BETA build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.31.0_Customize_Toolbar.dmg
From now, you can customize the Toolbar and add your favorite Tool Toggle (Where you can enable/disable the tool easily) 👍
You can open it by right-clicking on the Toolbar -> Customize Toolbar...
Please let me know if it solves your problem 😄
@cameroncooke commented on GitHub (Aug 27, 2021):
Looks good only thing I would change is maybe some of the icons are a
little unclear and the "small size" option doesn't really do anything much,
might be good to have an option to show labels instead of the small option?
Cameron.
On Fri, 27 Aug 2021 at 16:05, Nghia Tran @.***> wrote:
@sleeve commented on GitHub (Aug 27, 2021):
Amazing work @NghiaTranUIT on adding this feature! I think people are going to love it!
It seems to work pretty well for me but I would agree with @cameroncooke that the
Small Sizeoption seems unnecessary and some users will want andIcon and Textoption just like the Finder app has. As a user, it's hard to remember what those icons do without text labels. This may make the toolbar UI a bit more busy with text labels for all the buttons, users should still have the option to do that though. Hovering over the button to read the tooltip text is also a workaround for this but it's still a little annoying to constantly do, and there is also a slight delay until the tooltip text is displayed.Here are a few other minor issues I see with the beta build:
Customize Toolbarscreen feel like should all be the default grey color and not have the green color if they are already enabled. Once you move them to the toolbar though its fine if they display as green if they're enabled. It just looks a little confusing and busy seeing multiple colored icons within theCustomize Toolbarscreen. I think it would simplify the UX a bit if just the default grey color icons were always displayed within the Customize screen.macOS Monterey 12.0 beta 5 (21A5304g)
@NghiaTranUIT commented on GitHub (Aug 28, 2021):
Thanks for your detailed feedback @sleeve @cameroncooke, I appreciate it 🙇
All of your points are reasonable, and I'm fixing it now 👍
@NghiaTranUIT commented on GitHub (Aug 28, 2021):
Hey @sleeve and @cameroncooke, I've fixed all your mentioned issues. However, there is a problem:
In order to use Icon + Label, Icon Only, or Label Only, the main window must be use
.toolbarStyle = .unified. As a result, the toolbar size will become bigger than the original toolbar (.unifiedCompact). See the screenshot to see the difference.If I use the
.unifiedCompactmode, macOS doesn't display the "Icon + Label, Icon Only, or Label Only" menu, only Use Small Sizes.IMO, the
unifiedstyle is a really bad design because the toolbar now takes more space.To fix it, I did a little hack, and add the "Use Compact Mode" in Customize Toolbar Palette window. When we enable it, it will become the original mode, but it also lets you select an "Icon and Label" as usual.
Screenshot
Video:
https://www.dropbox.com/s/nutyd85dqpc1yht/CleanShot%202021-08-28%20at%2017.39.47.mp4?dl=0
If you'd like to test, please try this Beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.31.0_Improve_Customize_Toolbar_v2.dmg
It works seamlessly on macOS 11, but has a little issue on macOS 12 (I'm finding a solution)
@sleeve commented on GitHub (Aug 28, 2021):
@NghiaTranUIT Looking a lot better! That seems like a good solution to support the multiple view/toolbar sizes. I don't personally mind the taller toolbar but it would be nice to retain the smaller toolbar size that users are familiar with.
Just a few more minor issues that I see with this build. I'm only using macOS 12.0 beta 5 so not sure if these also occur on macOS 11.x. I'm also not sure if these are the "little issue" that you're still working on.
Still seeing the "Use Small Size" option in the right click toolbar menu after both "Icon Only" and "Use Compact Mode" are selected. I would expect the right click toolbar menu options to always show the same options (Icon and Text, Icon Only, Text Only).
Compact mode only seems to work with "Icon Only"? Would it make more sense to add a new Show/View option of
Icon Only (Compact)that does the same thing? Instead of having a checkbox to enable it within the customize toolbar screen?Clicking on any toolbar button while on "Text Only" mode instantly switches the view back to "Icon and Text". So the "Text Only" mode still seems pretty broken.
Thanks for the quick work on this!
@NghiaTranUIT commented on GitHub (Aug 29, 2021):
Thanks for your useful feedback @sleeve, I love it 🥇
@NghiaTranUIT commented on GitHub (Aug 29, 2021):
Here is an update for macOS 12 @sleeve if you have encountered some crashes https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.31.0_Toolbar_v3.dmg 👍
I will release today and find a better solution for macOS 12 in the next updates 😄