mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 08:35:53 +03:00
[GH-ISSUE #815] WebSocket connection requests are held up by Proxyman until the client sends the first message #810
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#810
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DL444 on GitHub (Mar 12, 2021).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/815
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
2.19.0
macOS Version? (Ex. mac 10.14)
11.2.3
Steps to reproduce
{"info":"You are using a test api key"}. This means the server has received your connection request.demo.websocket.meExpected behavior
The server receives connection request immediately after connection.
Additional info
Being able to connect to the server without client sending the first message is useful in server-push-only scenarios. Of course, we can workaround this by having the client send a small message after initiating connection. But it feels wrong to me having to add additional code in order to workaround an issue in a debugging tool.
@NghiaTranUIT commented on GitHub (Mar 13, 2021):
Thanks for the detailed input. We will look at it this week and send you a beta build asap 👍
@BenTilbrook commented on GitHub (Mar 17, 2021):
I have a similar problem. Can you send me a beta build to test also?
@NghiaTranUIT commented on GitHub (Mar 18, 2021):
Sorry to hear that. I was super busy last week with other features. I'm on it now 😄
@NghiaTranUIT commented on GitHub (Mar 20, 2021):
Hey @BenTilbrook and @DL444 Sorry for the delay. Here is the beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.20.0_Bug_Websocket.dmg
The reason was Proxyman only makes a WS connection to the destination server as soon as it receives the first WS message from the client. It's wrong and causes the bug.
I fixed it. Proxyman should connect to the server as soon as it's a WS/WSS.
@DL444 commented on GitHub (Mar 20, 2021):
@NghiaTranUIT
I can confirm that the problem is now fixed.
@NghiaTranUIT commented on GitHub (Mar 20, 2021):
Thanks. I will ship this fix in the next release 🙌
@DL444 commented on GitHub (Mar 24, 2021):
Since the fix is now publicly released, I think it might be a good time to close this issue.