mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-27 00:55:57 +03:00
[GH-ISSUE #812] [BUG] Scripting Tool cannot handle URL querystring parameters containing square brackets #808
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#808
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @michaelhogg on GitHub (Mar 7, 2021).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/812
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
2.19.0 (21900)
macOS Version? (Ex. mac 10.14)
10.14.3
Steps to reproduce
deliver.kenticocloud.com:Toolsmenu >SSL Proxying List.Enabled SSL Proxying Toolcheckbox.deliver.kenticocloud.comto theInclude List.deliver.kenticocloud.com:Scriptingmenu >Script ListURL=*deliver.kenticocloud.com*GETUse WildcardInclude all subpaths of this URLcheckbox uncheckedRun Script on=ResponseonlySave & Activatebutton.Consolebutton to open the Scripting Console.Expected behavior
The Scripting Console should display:
Screenshot
Further details
If I remove
[eq]from the URL:and then load this modified URL in Chrome, the Scripting Console displays the expected output:
So it seems to be the
[eq]querystring parameter in square brackets which is causing theCouldn not build JSObject with URLerror ❌There is some discussion online about whether square brackets should be percent-encoded (
[]encoded as%5B%5D) to make a valid URL:As an example, the Kentico Kontent Delivery API expects unencoded square brackets:
system.type[eq]=articleelements.price[lt]=10elements.price[range]=10.5,50So I think Proxyman's Scripting Tool needs to be able to support unencoded square brackets in querystring parameters, without crashing with the
Couldn not build JSObject with URLerror.@NghiaTranUIT commented on GitHub (Mar 7, 2021):
Hey @michaelhogg, thanks for your detailed bug report. I love it 😄
I will check it out to make sure the Scripting is able to parse the unencoded square brackets and send you a BETA build this week 👍
@NghiaTranUIT commented on GitHub (Mar 7, 2021):
@michaelhogg Please check out this beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.19.0_Fix_URL_Scripting.dmg
Please let me know if it works for you 😄
@michaelhogg commented on GitHub (Mar 7, 2021):
Hey @NghiaTranUIT! 👋 Wow that was a quick response! 😃
Thank you so much for implementing a fix and sending me that beta build 🌟 I can confirm that my test URL (with the unencoded square brackets) is now working! ✅
I really appreciate you fixing this bug so quickly – thank you! 🥇 🎉
Proxyman is really awesome and I've just purchased a license today 🙂
@NghiaTranUIT commented on GitHub (Mar 8, 2021):
Wow. Thank you @michaelhogg so much for supporting Proxyman Team ❤️ 🌮
Feel free to ping us if you find any problems 😄