mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 16:45:57 +03:00
[GH-ISSUE #793] Wildcard domains not capturing as expected. #788
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#788
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @isadon on GitHub (Feb 19, 2021).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/793
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
Proxyman Version 2.18.0 (21800)
macOS Version? (Ex. mac 10.14)
macOS 11.2.1 (20D74)
Steps to reproduce
cloudfunctions.netWildcard to SSL Proxy List - you will see thatcloudfunctions.net*gets added....cloudfunctions.netWildcard to Allow White List, make sureInclude all Subpaths of this urlis checked.cloudfunctions.net*Wildcard entry from SSL Proxy List and add*.cloudfunctions.net*.cloudfunctions.netWildcard entry from Allow List to be*.cloudfunctions.net*.Expected behavior
Proxyman should capture the request when entering SSL Proxy List and Allow List Wildcard domain to be
cloudfunctions.netresult without having to add*.cloudfunction.net*as a Wildcard which will work. Entering that is pretty much entering a Regex, the user expects thatcloudfunction.netfor both SSL Proxy List and Allow white list should capture this scenario.@NghiaTranUIT commented on GitHub (Feb 20, 2021):
@donileo I suppose that if we want to:
*.cloudfunction.net(One asterisk(*) and Include all subpath is checked)I don't think that
cloudfunction.netshould match sub-domains too, because they're different.It might be a bug, I will check it out 👍
@isadon commented on GitHub (Feb 20, 2021):
@NghiaTranUIT I actually forgot to mention above that using
*.cloudfunctions.netfor SSL Proxy List and Allow list also doesn't capture the curl request. It has to be*.cloudfunctions.net*.When you add
*.cloudfunctions.netto SSL Proxy List it automatically becomes*.cloudfunctions.net*which seems like a separate bug? Maybe not..@NghiaTranUIT commented on GitHub (Feb 21, 2021):
It might be a bug. I'm investigating it and send you a beta build soon 👍
@NghiaTranUIT commented on GitHub (Mar 5, 2021):
Sorry for the delay, I'm so busy working on other tickets for the 2.19.0 release (https://github.com/ProxymanApp/Proxyman/milestone/102)
It's not a bug. We intentionally add the * to the end to make sure all subpaths of this domain are matched. Many people forget the append the trailing *, so Proxyman could not enable SSL Proxying.
Solution => For the wildcard domain, I present the prefix to make it clear that it's a wildcard. For instance, Wildcard:
*.cloudfunctions.net*It's a bug. I'm working on it now 👍
@NghiaTranUIT commented on GitHub (Mar 5, 2021):
Hey @donileo Let check out this Beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.18.0_Fix_Wildcard.dmg
From now,
*.cloudfunctions.net*in SSL Proxying and*.cloudfunctions.netwith "ON Include Subpath" on Whitelist will match your cURL.@isadon commented on GitHub (Mar 6, 2021):
Hi @NghiaTranUIT I have tested and believed the issue is now fixed. I am however seeing something new which is that when selecting to add the Wildcard To Allowlist and checking the Allow all Subpaths option back in SSL Proxy List a new entry gets added. I don't believe that’s normal as I should only see the items that I have added in SSL Proxy List. Below is a screenshot of what gets added.
The wildcard item in blue is what I initially had.. The item pointed to by the arrow gets added after adding the Wildcard to the Allow list.
@NghiaTranUIT commented on GitHub (Mar 7, 2021):
It's our decision to help people resolves their common mistakes:
Many Proxyman users didn't know that they have to enable SSL on a domain that they added to Block List / Allow List / Other tools. As a result, we've received a lot of questions about why the Block/Allow List doesn't work after adding a new rule.
The answer is quite simple. Just add a domain (in Block/Allow list) to SSL Proxying List or right-click on them -> Enable SSL Proxying.
To make it easier to use, we decide to automatically create a rule in SSL Proxying as soon as new rules are added in debugging tools.
From your case, it looks like a bug, because
*.cloudfunction.netis a wildcard, but it appears as a domain. I will fix it 👍