mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 08:35:53 +03:00
[GH-ISSUE #783] Cookies not parsed correctly on the Cookies tab #777
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#777
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pbartolome on GitHub (Feb 11, 2021).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/783
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
Version 2.17.0 (21700)
macOS Version? (Ex. mac 10.14)
10.15.7 (19H114)
Steps to reproduce
Inspect a request with a cookie value with some specific characters (E.g "==~"). In the Cookie's tab the cookie value is not parsed properly and discards everything after "==~"
Screenshots (optional)
@NghiaTranUIT commented on GitHub (Feb 11, 2021):
Thanks for the screenshot. I will fix it and send you a hotfix soon 👍
@NghiaTranUIT commented on GitHub (Feb 12, 2021):
@pbartolome Please check this beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.17.0_Fix_Cookie_Parser.dmg
It fixes the cookie parser 😄
@pbartolome commented on GitHub (Feb 12, 2021):
@NghiaTranUIT Great, that was a quick fix!, it works now.
Just a suggestion, maybe the response should say "Set-Cookie" instead of "Cookies", It will be weird to have a "Cookie" header on a response ;)
Thanks!
@NghiaTranUIT commented on GitHub (Feb 12, 2021):
Ah right. Make sense. I will change the title 👍
@NghiaTranUIT commented on GitHub (Feb 12, 2021):
It's fixed in this beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.17.0_Better_UI_For_Helper_Tool.dmg
Thank you so much for the bug report 🙇
@pbartolome commented on GitHub (Feb 15, 2021):
In the response, the Set-Cookie is still note quite correct. E.g the header response of https://samesite-sandbox.glitch.me/:
Proxyman is showing a list of cookies that are really cookie attributes:
Splitting cookies with
;won't work to parse the Set-Cookie header. In that case a different strategy is neededhttps://tools.ietf.org/html/rfc6265#section-4.1
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie
@NghiaTranUIT commented on GitHub (Feb 16, 2021):
Look like I have to implement the Set-Cookie TableView like Safari Inspector
@NghiaTranUIT commented on GitHub (Feb 16, 2021):
At the first glance, I thought that I would like to implement like the following design, which you can collapse/expand their attributes for each Key-Value
However, we have to sacrifice the multiple-line and I don't think it's a good deal, since it's really difficult to copy a text if it's too long (has ...)
Let try my improvised build 😄 https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.17.0_Better_UI_Set-Cookie.dmg
By this way, the multiple line is remained and it's easier to copy
@NghiaTranUIT commented on GitHub (Feb 16, 2021):
@pbartolome let me know how you feels. Thanks 🙌
@pbartolome commented on GitHub (Feb 16, 2021):
much better, thanks for acting so fast to the reported feedback!
It seems that the Set-Cookie tab in the 'breakpoint' view has some bugs

@NghiaTranUIT commented on GitHub (Feb 16, 2021):
Thanks. It's a bug. I suppose that I should disable the Set-Cookie in the Response. So, you only can edit the SetCookie Value from the Header Tab.
The reason why I choose this way because it's really difficult to implement this feature. Maybe I will improve it later
@NghiaTranUIT commented on GitHub (Feb 17, 2021):
I fixed this issue here: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.17.0_Fix_Set_Cookie_Breakpoint_And_Missing_Tabs_In_Compose.dmg
Thank you for raising the bug 😄 👍