starred/Proxyman

Fork 0

mirror of https://github.com/ProxymanApp/Proxyman.git synced 2026-04-28 01:25:52 +03:00

[GH-ISSUE #738] Duplicating rules leads to data loss #736

New issue

Closed

opened 2026-03-03 19:21:25 +03:00 by kerem · 7 comments

kerem commented

2026-03-03 19:21:25 +03:00

Owner

Originally created by @mprice-banno on GitHub (Dec 22, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/738

Originally assigned to: @NghiaTranUIT on GitHub.

Proxyman version? (Ex. Proxyman 1.4.3)

2.15.0 (21500)

macOS Version? (Ex. mac 10.14)

Multiple, 10.15.6 and 10.13.6

Steps to reproduce

It look me a little while to figure out what was happening here, I have 50+ rules, and most of them were created as duplicates of other scripts and then edited. I would come back later and find the script would be incorrect. This was happening a lot.

It's easy to reproduce from a fresh install.

Fresh install of app
Open Scripting window
Add new rule, name it Rule 1, use /url1 for the URL and add //rule 1 at the top of the script.
Save the rule.
Duplicate Rule 1 (The focus moves from Rule 1 to the duplicated Rule 1 copy)
Edit the duplicate, change name to Rule 2, use /url2 for the URL and add //rule 2 at the top of the script.
Save Rule 2
Select/highlight Rule 1 from the list
Duplicate Rule 1 again

At this point the focus has moved from Rule 1 to Rule 2, but the contents of Rule 2's script, are now the same as Rule1's, or possible Rule 1 copy (the second duplication). If you switch back and forth the Rule 2 Name and URL are correct, but the script contents are wrong.

I have confirmed that the on-disk contents of the rule 2 script have been replaced with rule 1's.

This might be hard to follow, so here's a video.

Expected behavior

When a rule is duplicated the focus bar should always switch to the newly duplicated rule.
Existing rules should not change.

Screenshots (optional)

Originally created by @mprice-banno on GitHub (Dec 22, 2020). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/738 Originally assigned to: @NghiaTranUIT on GitHub. ### Proxyman version? (Ex. Proxyman 1.4.3) 2.15.0 (21500) ### macOS Version? (Ex. mac 10.14) Multiple, 10.15.6 and 10.13.6 ### Steps to reproduce It look me a little while to figure out what was happening here, I have 50+ rules, and most of them were created as duplicates of other scripts and then edited. I would come back later and find the script would be incorrect. This was happening a lot. It's easy to reproduce from a fresh install. - Fresh install of app - Open Scripting window - Add new rule, name it Rule 1, use `/url1` for the URL and add `//rule 1` at the top of the script. - Save the rule. - Duplicate Rule 1 (The focus moves from Rule 1 to the duplicated Rule 1 copy) - Edit the duplicate, change name to Rule 2, use `/url2` for the URL and add `//rule 2` at the top of the script. - Save Rule 2 - Select/highlight Rule 1 from the list - Duplicate Rule 1 again At this point the focus has moved from Rule 1 to Rule 2, but the contents of Rule 2's script, are now the same as Rule1's, or possible Rule 1 copy (the second duplication). If you switch back and forth the Rule 2 Name and URL are correct, but the script contents are wrong. I have confirmed that the on-disk contents of the rule 2 script have been replaced with rule 1's. This might be hard to follow, so here's a video. ![ProxyManRuleCorruption](https://user-images.githubusercontent.com/58708906/102908093-d1425580-442b-11eb-86e7-0041212d6b04.gif) ### Expected behavior - When a rule is duplicated the focus bar should always switch to the newly duplicated rule. - Existing rules should not change. ### Screenshots (optional)

kerem

2026-03-03 19:21:25 +03:00

closed this issue
added the
bug

✅ Done
labels

kerem commented

2026-03-03 19:21:26 +03:00

Author

Owner

@mprice-banno commented on GitHub (Dec 22, 2020):

There is a similar related issue with any of the tools that allow the duplication of a rule, breakpoints, block and allow lists etc.
When you duplicate a rule the focus moves to the rule above, not to the new duplicated rule. No data loss with these rules as far as I can tell.

@mprice-banno commented on GitHub (Dec 22, 2020): There is a similar related issue with any of the tools that allow the duplication of a rule, breakpoints, block and allow lists etc. When you duplicate a rule the focus moves to the rule above, not to the new duplicated rule. No data loss with these rules as far as I can tell.

kerem commented

2026-03-03 19:21:26 +03:00

Author

Owner

@NghiaTranUIT commented on GitHub (Dec 23, 2020):

Thanks for the detailed bug report. I'm fixing it now 👍 Will send you a BETA build asap

@NghiaTranUIT commented on GitHub (Dec 23, 2020): Thanks for the detailed bug report. I'm fixing it now 👍 Will send you a BETA build asap

kerem commented

2026-03-03 19:21:26 +03:00

Author

Owner

@mprice-banno commented on GitHub (Dec 23, 2020):

Thanks Nghia!

@mprice-banno commented on GitHub (Dec 23, 2020): Thanks Nghia!

kerem commented

2026-03-03 19:21:26 +03:00

Author

Owner

@NghiaTranUIT commented on GitHub (Dec 24, 2020):

Hey @mprice-banno, this BETA build will fix the bug: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.15.1_Fix_Duplicate_Scripts_Lost_Data.dmg

Please let me know if it works for you 👍

@NghiaTranUIT commented on GitHub (Dec 24, 2020): Hey @mprice-banno, this BETA build will fix the bug: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.15.1_Fix_Duplicate_Scripts_Lost_Data.dmg Please let me know if it works for you 👍

kerem commented

2026-03-03 19:21:26 +03:00

Author

Owner

@mprice-banno commented on GitHub (Dec 24, 2020):

Thanks @NghiaTranUIT so far so good! I'll keep testing with it today.

@mprice-banno commented on GitHub (Dec 24, 2020): Thanks @NghiaTranUIT so far so good! I'll keep testing with it today.

kerem commented

2026-03-03 19:21:26 +03:00

Author

Owner

@mprice-banno commented on GitHub (Jan 5, 2021):

No more issues that I've run into since the fix. Thanks @NghiaTranUIT

@mprice-banno commented on GitHub (Jan 5, 2021): No more issues that I've run into since the fix. Thanks @NghiaTranUIT

kerem commented

2026-03-03 19:21:26 +03:00

Author

Owner

@NghiaTranUIT commented on GitHub (Jan 6, 2021):

Just a friendly reminder that the latest build 2.15.2 has already included this fix 🙌

@NghiaTranUIT commented on GitHub (Jan 6, 2021): Just a friendly reminder that the latest build 2.15.2 has already included this fix 🙌