mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 00:25:56 +03:00
[GH-ISSUE #644] [BUG] Stop recording button does not disable system proxy #643
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#643
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yeradis on GitHub (Sep 30, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/644
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
Version 2.8.0 (20800) but this is happening on previous versions too
macOS Version? (Ex. mac 10.14)
macOS Cataline 10.15.7 (19H2)
Proxy Helper Tool
com.proxyman.NSProxy.HelperTool Version 1.2.0
Steps to reproduce
Touch the Stop recording button
Expected behavior
System proxy should be disabled so requests goes directly to servers instead of thought Proxyman
ISSUE:
Right now the Stop recording button is just doing that, you dont see any logs on proxy man
BUT
@NghiaTranUIT commented on GitHub (Sep 30, 2020):
It makes sense to disable the macOS System Proxy, doesn't record any things, and disable all Debugging Tools if the Recording Button is OFF.
I will improve the behavior in the next release 👍
@NghiaTranUIT commented on GitHub (Sep 30, 2020):
Sorry, but after careful consideration, we decide to keep the current behavior, because it's a Recording button, not a Start/Stop a Proxyman app.
So, if we turn the recording button OFF, traffic from Mac and remote devices, macOS System Proxy, or Tools should remain, but not show on the app.
We decide this approach because there are some scenarios that if you would block some domains or apply certain tools but don't record anything. It still works. If we follow your proposal, all tools are not applied and it behaves like an On/OFF app button.
I did research on Fiddler and Charles app, it's the same behavior. Therefore, maybe it's universally accepted 🤔
I understand that it might be unclear, the only way to make it clear is that we introduce both ON/OFF app button and the Recording button. However, it's more confusing because there are two buttons on the Main Toolbar that are likely the same 😕
I will research further and collect many users' feedback to find a suitable UIUX solution 😄
Sorry for this inconvenience.
To work around your situation, you can turn off the System Proxy by CMD+Shift+O or enable/disable tools from its enabled checkbox.
@yeradis commented on GitHub (Oct 2, 2020):
@NghiaTranUIT thanks for taking your time replying
Have not checked Fiddler, and after checking Charles, it behaves in a similar way when there is some mappings, which for me, even in Charles feels wrong
Mainly because of the idea i have that intercepting traffic is a different action to record it
But thanks anyway, i just need to remember another shortcut 😢 😄
@NghiaTranUIT commented on GitHub (Oct 2, 2020):
Thank you for understanding. I actually implemented it as your first proposal, but after a debate with my teammates. It turns out it causes different behavior than the initial intention.
I will open this ticket and introduce the ON/OFF button, besides the Recording button (I will change the icon), and put one of them into the Custom toolbars. (See the screenshot). Therefore, you can custom as you wish 👍 😄