[GH-ISSUE #623] [BUG] Crashed on Shared State (Scripting) on prior macOS 10.15 #620

Open
opened 2026-03-03 19:20:24 +03:00 by kerem · 1 comment
Owner

Originally created by @NghiaTranUIT on GitHub (Sep 15, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/623

Originally assigned to: @NghiaTranUIT on GitHub.

Description

Currently, we are using setValue(_:forProperty:) to set an empty Dictionary to a global object. It enables the user can share their state between each onRequest and onResponse call.

It works fine in macOS 10.15, but crashed on prior macOS.

Screen Shot 2020-09-15 at 09 13 08

Acceptance Criteria

  • Disable this feature on prior macOS 10.15 since it's unsafe. It's exclusive for macOS 10.15+
Originally created by @NghiaTranUIT on GitHub (Sep 15, 2020). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/623 Originally assigned to: @NghiaTranUIT on GitHub. ### Description Currently, we are using [setValue(_:forProperty:)](https://developer.apple.com/documentation/javascriptcore/jsvalue/1451676-setvalue) to set an empty Dictionary to a global object. It enables the user can share their state between each `onRequest` and `onResponse` call. It works fine in macOS 10.15, but crashed on prior macOS. <img width="1529" alt="Screen Shot 2020-09-15 at 09 13 08" src="https://user-images.githubusercontent.com/5878421/93157070-b0cf7480-f733-11ea-8cf0-5441df897c4a.png"> #### Acceptance Criteria - Disable this feature on prior macOS 10.15 since it's unsafe. It's exclusive for macOS 10.15+
Author
Owner

@NghiaTranUIT commented on GitHub (Sep 15, 2020):

Fixed https://github.com/ProxymanApp/Proxyman/issues/598#issuecomment-692456533

<!-- gh-comment-id:692456654 --> @NghiaTranUIT commented on GitHub (Sep 15, 2020): Fixed https://github.com/ProxymanApp/Proxyman/issues/598#issuecomment-692456533
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#620
No description provided.