[GH-ISSUE #539] Improve How we fetch the remote Certificate #538

Open
opened 2026-03-03 19:19:38 +03:00 by kerem · 1 comment
Owner

Originally created by @NghiaTranUIT on GitHub (Jul 1, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/539

Originally assigned to: @NghiaTranUIT on GitHub.

Description

Currently, we're using OpenSSL to fetch the remote certificate, but it doesn't work well in the following scenario:

  • Support External Proxy (HTTP/HTTPS and Socks5)
  • Custom Client Certificate
  • Get some errors if the domain is on an internal network
  • Some crashes on OpenSSL
  • Hard to extend the feature since it's low-level code

It's time to refactor it and find a better alternative.

Acceptance Criteria

  • Use NIOSSLClientHandler and NIOSSLCustomVerificationCallback to get the Remote Certificate during Certificate Evaluation
  • Remove all OpenSSL and relevant code
  • Test some edge cases and make sure it works
Originally created by @NghiaTranUIT on GitHub (Jul 1, 2020). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/539 Originally assigned to: @NghiaTranUIT on GitHub. ### Description Currently, we're using OpenSSL to fetch the remote certificate, but it doesn't work well in the following scenario: - Support External Proxy (HTTP/HTTPS and Socks5) - Custom Client Certificate - Get some errors if the domain is on an internal network - Some crashes on OpenSSL - Hard to extend the feature since it's low-level code It's time to refactor it and find a better alternative. ### Acceptance Criteria - Use `NIOSSLClientHandler` and `NIOSSLCustomVerificationCallback` to get the Remote Certificate during Certificate Evaluation - Remove all OpenSSL and relevant code - Test some edge cases and make sure it works
Author
Owner

@NghiaTranUIT commented on GitHub (Jul 2, 2020):

All done 🎉

https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.1.0_Improve_Server_Fetcher.dmg

<!-- gh-comment-id:653064379 --> @NghiaTranUIT commented on GitHub (Jul 2, 2020): All done 🎉 https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.1.0_Improve_Server_Fetcher.dmg
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#538
No description provided.