[GH-ISSUE #522] [BUG] Repeated request has different header orders #519

Open
opened 2026-03-03 19:19:30 +03:00 by kerem · 4 comments
Owner

Originally created by @NghiaTranUIT on GitHub (Jun 7, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/522

Originally assigned to: @NghiaTranUIT on GitHub.

Description

The header order of the repeated requests has different from the original one. Thus, it causes annoying when checking the header key.

How to reproduce

  1. Repeat any request
  2. Observer the header order of them
  3. They are in a different order

Acceptance Criteria

  • Repeated flow has the same header order and query order
Originally created by @NghiaTranUIT on GitHub (Jun 7, 2020). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/522 Originally assigned to: @NghiaTranUIT on GitHub. ### Description The header order of the repeated requests has different from the original one. Thus, it causes annoying when checking the header key. ### How to reproduce 1. Repeat any request 2. Observer the header order of them 3. They are in a different order ### Acceptance Criteria - Repeated flow has the same header order and query order
Author
Owner

@NghiaTranUIT commented on GitHub (Jun 7, 2020):

Technically, we use Moya to construct a request, but it stores the header in a dictionary. So, there is no order. We should remove it and construct a request by using URLSession as usual 🙌

<!-- gh-comment-id:640225152 --> @NghiaTranUIT commented on GitHub (Jun 7, 2020): Technically, we use Moya to construct a request, but it stores the header in a dictionary. So, there is no order. We should remove it and construct a request by using URLSession as usual 🙌
Author
Owner

@shirshak55 commented on GitHub (Jun 11, 2020):

do ordering matters ? In browser do order remain same ?

<!-- gh-comment-id:642425849 --> @shirshak55 commented on GitHub (Jun 11, 2020): do ordering matters ? In browser do order remain same ?
Author
Owner

@NghiaTranUIT commented on GitHub (Jun 12, 2020):

The order is not really the matter, but if they are the same, I can easily compare the headers without finding each other. It's a small thing to improve productivity 👍

<!-- gh-comment-id:643293462 --> @NghiaTranUIT commented on GitHub (Jun 12, 2020): The order is not really the matter, but if they are the same, I can easily compare the headers without finding each other. It's a small thing to improve productivity 👍
Author
Owner

@NghiaTranUIT commented on GitHub (Jun 12, 2020):

Support on https://github.com/ProxymanApp/Proxyman/issues/500#issuecomment-643294010, but the order doesn't guarantee that it's exactly the order even though I use URLSession, but it's better than the current build 🤚

<!-- gh-comment-id:643294441 --> @NghiaTranUIT commented on GitHub (Jun 12, 2020): Support on https://github.com/ProxymanApp/Proxyman/issues/500#issuecomment-643294010, but the order doesn't guarantee that it's exactly the order even though I use URLSession, but it's better than the current build 🤚
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#519
No description provided.