mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 08:35:53 +03:00
[GH-ISSUE #520] [BUG] IP v4 is not correct for Remote Device #517
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#517
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @NghiaTranUIT on GitHub (Jun 7, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/520
Originally assigned to: @NghiaTranUIT on GitHub.
Description
For some reason, the logic to detect the current IP v4 is not correct. It presents the different one.
A user helps us to reproduce it. The code returns two IPs and the first one is not correct.
We should fix it
Acceptance Criteria
@NghiaTranUIT commented on GitHub (Jun 27, 2020):
Fixed 🤚 https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.0.1_Fix_IP_Address.dmg
@crankygeek commented on GitHub (Jun 29, 2020):
@NghiaTranUIT Using Version 2.1.0 (20100), I'm still seeing the 169.* addresses for my remote devices (iPads). Should that no longer be the case, or am I misunderstanding the purpose of this issue?
(I actually came here to add a suggesting for combining clients into folders for this reason, as well as iPv6 addresses. I can still file that separately if you think it's worth considering.)
@NghiaTranUIT commented on GitHub (Jun 30, 2020):
Hi @crankygeek, please Hold the Option Key and Click on the Wifi icon (System Menu Bar), and see what the IP Address is. Is it the same with
162.*?If it's the same, it's correct behavior because there is no
192.*, Proxyman will return the possible values.If there is
192.*IP, I will return it because it's likely the correct IP that the Remove Device can connectThe problem is that there is no reliable way to get extract IP address from current Wifi, so Proxyman will receive all available IPs and figure it out which one is right 😄
@NghiaTranUIT commented on GitHub (Jun 30, 2020):
Can you elaborate? I'm not sure if I understand 🤔
@crankygeek commented on GitHub (Jun 30, 2020):
@NghiaTranUIT Sure!
I typically have 3-5 iPads proxying through my Mac. For whatever reasons, each one may show up under multiple addresses in Proxyman. For example:
These are all three the same device, but they are listed as three separate remote devices. Add additional devices and the list becomes a lot to manage. I was really happy to see Device Nicknames get added, and it helps a bit, but any particular session may send traffic to any of the IP addresses, so it's not possible to select one to observe all traffic. I was thinking that adding a device folder, similar to a Pin folder, could help. I could assign all the various IPs for a particular device to a folder, then select that folder to view all traffic for that device.
@crankygeek commented on GitHub (Jul 8, 2020):
@NghiaTranUIT Was that description helpful?
@NghiaTranUIT commented on GitHub (Jul 9, 2020):
I understand your situation. Looks like it's a bug because the same device creates 3 different IP Folders => It should be only one.
On the other hand, the idea about the
Device Folder, to show all traffic from all devices is reasonable. I will consider to support it in the next release 👍@crankygeek commented on GitHub (Jul 9, 2020):
Small clarification for my request - I'd like to be able to group devices into individual folders (assuming multiple IPs keep happening), e.g.:
@crankygeek commented on GitHub (Jan 14, 2021):
Hi @NghiaTranUIT
I was just chatting with @mprice-banno about 169. addresses still showing up in the device list (using Version 2.16.0 (21600)).
He discovered that the IP is only included if the device is tethered to the Mac while proxying. That probably explains why I saw this after your earlier fix, because I mainly only use my devices while tethered.
Comparing with the info provided by the user who you mentioned in the issue description, is that perhaps a different case that isn't being accounted for?
I've attached a .zip file an example request log, as well as the output from
ifconfigwith just the 169 interface info, in case it's helpful.169-network-stuff.zip
Thanks!
@NghiaTranUIT commented on GitHub (Jan 15, 2021):
Thanks for the detailed report @crankygeek . Let me try to reproduce it on my end and see if I can fix it 👍