[GH-ISSUE #499] Whitelist feature is allowing other domains #494

Open
opened 2026-03-03 19:19:16 +03:00 by kerem · 10 comments
Owner

Originally created by @adamwinn on GitHub (May 6, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/499

Originally assigned to: @NghiaTranUIT on GitHub.

Proxyman version? (Ex. Proxyman 1.4.3)

Version 1.23.0 (12300)

macOS Version? (Ex. mac 10.14)

10.15.4

Steps to reproduce

Setup a whitelist for localhost.charlesproxy.com
Clear the session
Visit yahoo.com using Brave browser
Note the non-localhost domains shown in Proxyman

Expected behavior

Only localhost.charlesproxy.com domains should be shown in Proxyman. No *yahoo* domains should be shown

Screenshots (optional)

Screen Shot 2020-05-05 at 8 42 15 PM
Screen Shot 2020-05-05 at 8 42 53 PM

Originally created by @adamwinn on GitHub (May 6, 2020). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/499 Originally assigned to: @NghiaTranUIT on GitHub. ### Proxyman version? (Ex. Proxyman 1.4.3) Version 1.23.0 (12300) ### macOS Version? (Ex. mac 10.14) 10.15.4 ### Steps to reproduce Setup a whitelist for `localhost.charlesproxy.com` Clear the session Visit `yahoo.com` using Brave browser Note the non-localhost domains shown in Proxyman ### Expected behavior Only `localhost.charlesproxy.com` domains should be shown in Proxyman. No `*yahoo*` domains should be shown ### Screenshots (optional) ![Screen Shot 2020-05-05 at 8 42 15 PM](https://user-images.githubusercontent.com/3028964/81134171-2cf9b600-8f11-11ea-9e9c-475e37454876.jpg) ![Screen Shot 2020-05-05 at 8 42 53 PM](https://user-images.githubusercontent.com/3028964/81134182-32ef9700-8f11-11ea-9212-e7f4c55b81cf.jpg)
Author
Owner

@NghiaTranUIT commented on GitHub (May 6, 2020):

Hey, I'm able to reproduce this bug. It looks like Proxyman forgets to stop all alive Brave's connections after applying the Whitelist.

You can workaround by using Tool -> Clear Session to remove all Brave flows.

I will fix it in next release 👍

<!-- gh-comment-id:624416165 --> @NghiaTranUIT commented on GitHub (May 6, 2020): Hey, I'm able to reproduce this bug. It looks like Proxyman forgets to stop all alive Brave's connections after applying the Whitelist. You can workaround by using Tool -> Clear Session to remove all Brave flows. I will fix it in next release 👍
Author
Owner

@NghiaTranUIT commented on GitHub (May 23, 2020):

@adamwinn Beta build here: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.23.0_Monospace_Font.dmg

Basically, when Blacklist or Whitelist setting is updated, all connection will be closed to make sure that it won't appear anymore 👍

<!-- gh-comment-id:632978971 --> @NghiaTranUIT commented on GitHub (May 23, 2020): @adamwinn Beta build here: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.23.0_Monospace_Font.dmg Basically, when Blacklist or Whitelist setting is updated, all connection will be closed to make sure that it won't appear anymore 👍
Author
Owner

@adamwinn commented on GitHub (May 23, 2020):

Thanks for the build! I'm still seeing *yahoo* results tho.

Screen Shot 2020-05-22 at 9 43 46 PM

<!-- gh-comment-id:632979552 --> @adamwinn commented on GitHub (May 23, 2020): Thanks for the build! I'm still seeing `*yahoo*` results tho. ![Screen Shot 2020-05-22 at 9 43 46 PM](https://user-images.githubusercontent.com/3028964/82720935-6eaa9080-9c75-11ea-851f-b8f78304fd5c.jpg)
Author
Owner

@NghiaTranUIT commented on GitHub (May 23, 2020):

Hm, interesting. Let me investigate it again 😬

<!-- gh-comment-id:632979631 --> @NghiaTranUIT commented on GitHub (May 23, 2020): Hm, interesting. Let me investigate it again 😬
Author
Owner

@NghiaTranUIT commented on GitHub (May 23, 2020):

I'm not sure but I couldn't reproduce it from the build I sent you 🤔

Here is my scenario

  1. Use Brave and open yahoo.com -> See a lot request on Proxyman
  2. Open Whitelist and add localhost.charlesproxy.com
  3. Clear all flows
  4. Try to open localhost.charlesproxy.com on Brave
  5. Nothing appears except the localhost.charlesproxy.com

I tried on different domains and the result is the same. Can you help me to check it out? Drag the beta build to ~/Application and open it

<!-- gh-comment-id:632980367 --> @NghiaTranUIT commented on GitHub (May 23, 2020): I'm not sure but I couldn't reproduce it from the build I sent you 🤔 Here is my scenario 1. Use Brave and open yahoo.com -> See a lot request on Proxyman 2. Open Whitelist and add `localhost.charlesproxy.com` 3. Clear all flows 4. Try to open `localhost.charlesproxy.com` on Brave 5. Nothing appears except the `localhost.charlesproxy.com` I tried on different domains and the result is the same. Can you help me to check it out? Drag the beta build to ~/Application and open it
Author
Owner

@adamwinn commented on GitHub (May 23, 2020):

Step 4 should be: Open yahoo.com again and you shouldn't see any yahoo results

<!-- gh-comment-id:632980843 --> @adamwinn commented on GitHub (May 23, 2020): Step 4 should be: Open yahoo.com again and you shouldn't see any yahoo results
Author
Owner

@NghiaTranUIT commented on GitHub (May 23, 2020):

Screen Shot 2020-05-23 at 11 01 18

Yes, and the same, other domains won't appear 🤔

Btw, I will keep investigating, maybe there are some edge cases that I haven't covered yet 🌮

<!-- gh-comment-id:632981098 --> @NghiaTranUIT commented on GitHub (May 23, 2020): <img width="1661" alt="Screen Shot 2020-05-23 at 11 01 18" src="https://user-images.githubusercontent.com/5878421/82721126-c03e3400-9ce4-11ea-980c-b2affde7d59a.png"> Yes, and the same, other domains won't appear 🤔 Btw, I will keep investigating, maybe there are some edge cases that I haven't covered yet 🌮
Author
Owner

@adamwinn commented on GitHub (Jun 7, 2020):

I'm on Version 1.24.0 (12400) now and attached is a video showing what I'm seeing. yahoo domains appear in the list when they shouldn't

https://streamable.com/adu4sp

<!-- gh-comment-id:640161293 --> @adamwinn commented on GitHub (Jun 7, 2020): I'm on Version 1.24.0 (12400) now and attached is a video showing what I'm seeing. yahoo domains appear in the list when they shouldn't https://streamable.com/adu4sp
Author
Owner

@NghiaTranUIT commented on GitHub (Jun 7, 2020):

@adamwinn let check out this build: https://github.com/ProxymanApp/Proxyman/issues/500#issuecomment-640187667

Whitelist has been refactored and fixed your case 👍

<!-- gh-comment-id:640189506 --> @NghiaTranUIT commented on GitHub (Jun 7, 2020): @adamwinn let check out this build: https://github.com/ProxymanApp/Proxyman/issues/500#issuecomment-640187667 Whitelist has been refactored and fixed your case 👍
Author
Owner

@adamwinn commented on GitHub (Jun 7, 2020):

It's still happening, although the error message is different now

Screen Shot 2020-06-07 at 10 57 05 AM

<!-- gh-comment-id:640248218 --> @adamwinn commented on GitHub (Jun 7, 2020): It's still happening, although the error message is different now ![Screen Shot 2020-06-07 at 10 57 05 AM](https://user-images.githubusercontent.com/3028964/83974884-c1a75900-a8ad-11ea-8ff9-d9a4e76a5abc.jpg)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#494
No description provided.