mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-27 09:05:54 +03:00
[GH-ISSUE #499] Whitelist feature is allowing other domains #494
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#494
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @adamwinn on GitHub (May 6, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/499
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
Version 1.23.0 (12300)
macOS Version? (Ex. mac 10.14)
10.15.4
Steps to reproduce
Setup a whitelist for
localhost.charlesproxy.comClear the session
Visit
yahoo.comusing Brave browserNote the non-localhost domains shown in Proxyman
Expected behavior
Only
localhost.charlesproxy.comdomains should be shown in Proxyman. No*yahoo*domains should be shownScreenshots (optional)
@NghiaTranUIT commented on GitHub (May 6, 2020):
Hey, I'm able to reproduce this bug. It looks like Proxyman forgets to stop all alive Brave's connections after applying the Whitelist.
You can workaround by using Tool -> Clear Session to remove all Brave flows.
I will fix it in next release 👍
@NghiaTranUIT commented on GitHub (May 23, 2020):
@adamwinn Beta build here: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.23.0_Monospace_Font.dmg
Basically, when Blacklist or Whitelist setting is updated, all connection will be closed to make sure that it won't appear anymore 👍
@adamwinn commented on GitHub (May 23, 2020):
Thanks for the build! I'm still seeing
*yahoo*results tho.@NghiaTranUIT commented on GitHub (May 23, 2020):
Hm, interesting. Let me investigate it again 😬
@NghiaTranUIT commented on GitHub (May 23, 2020):
I'm not sure but I couldn't reproduce it from the build I sent you 🤔
Here is my scenario
localhost.charlesproxy.comlocalhost.charlesproxy.comon Bravelocalhost.charlesproxy.comI tried on different domains and the result is the same. Can you help me to check it out? Drag the beta build to ~/Application and open it
@adamwinn commented on GitHub (May 23, 2020):
Step 4 should be: Open yahoo.com again and you shouldn't see any yahoo results
@NghiaTranUIT commented on GitHub (May 23, 2020):
Yes, and the same, other domains won't appear 🤔
Btw, I will keep investigating, maybe there are some edge cases that I haven't covered yet 🌮
@adamwinn commented on GitHub (Jun 7, 2020):
I'm on Version 1.24.0 (12400) now and attached is a video showing what I'm seeing. yahoo domains appear in the list when they shouldn't
https://streamable.com/adu4sp
@NghiaTranUIT commented on GitHub (Jun 7, 2020):
@adamwinn let check out this build: https://github.com/ProxymanApp/Proxyman/issues/500#issuecomment-640187667
Whitelist has been refactored and fixed your case 👍
@adamwinn commented on GitHub (Jun 7, 2020):
It's still happening, although the error message is different now