mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-05-01 11:05:56 +03:00
[GH-ISSUE #382] Trailing slashes are removed when sending modified URLs with trailing slashes #378
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#378
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @crankygeek on GitHub (Jan 25, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/382
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
1.14.1 (11410)
macOS Version? (Ex. mac 10.14)
macOS 10.14.6
Steps to reproduce
I've noticed that when editing a URL to add a new path, my trailing slash (required by our API) is getting dropped when it's sent. If I end the new path with double slashes (//) the request is sent with the expected single slash.
This isn't something I've done previous to 1.14.1, so I don't know if this is a new bug, but I noticed Issue 376 addressed an issue with double slashes and I wonder if perhaps this is a regression due to that change?
Expected behavior
Full user entered path is sent
Screenshots (optional)
@NghiaTranUIT commented on GitHub (Jan 25, 2020):
Hey @crankygeek, it looks like the behavior is not correct for composing the request with an extra slash. I'm looking on it and other tickets too 👍
Thank for raising them 🥇
@NghiaTranUIT commented on GitHub (Mar 7, 2020):
Hey @crankygeek let try a BETA build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.17.1_Trailing_Slash_Missing.dmg
Sorry for being late, I forgot it 😢. It's done now 👍
Thank you for reporting
@crankygeek commented on GitHub (Mar 9, 2020):
@NghiaTranUIT Looks good in 1.18.0.
I also tested by adding double slashes at the end and I see the extra slash isn't removed. I think this is fine, since it's entered by the user and should be honored, but thought I'd mention it since it was in my initial report.
@NghiaTranUIT commented on GitHub (Mar 10, 2020):
Yup, I test around other apps and it would be better to keep whatever the user enter 😄
In the past, I fixed the bug where this weird URL: www.myapi.com//version?tag=1.0. All slashes must be retained 👍