mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 08:35:53 +03:00
[GH-ISSUE #370] Repeat doesn't preserve query items #366
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#366
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cameroncooke on GitHub (Jan 9, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/370
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
1.13.1macOS Version? (Ex. mac 10.14)
10.15.3 Beta (19D49f)
Steps to reproduce
Repeat a request which has query items.
Expected behavior
Repeated request should have identical payload and query string as original.
@NghiaTranUIT commented on GitHub (Jan 10, 2020):
Hi @cameroncooke, so far from what I testing with complex Query item and the repeated request:
=> It's correct behavior
I'm not sure how can I reproduce your case. Can you give me an example how the Query look like that cause the bug? 🤔
@cameroncooke commented on GitHub (Jan 10, 2020):
I think I've narrowed down the issue, it seems to occur when repeating a
POSTrequests which have query items.When repeating the query items are converted into form values i.e.
key/value pairs and are moved to the HTTP body and the
Content-Typeischanged to
application/x-www-form-urlencoded; charset=utf-8.I would expect to repeat the request in an identical format. Also, query
items on POST requests are perfectly valid. If you're using
Alamofireitwould appear it's conveniently or not conveniently trying to be cleaver and
rewrite the request. As a proxy tool for debugging, I would not expect my
requests to be changed in this way.
When testing with Charles it works as expected an identical request is
repeated.
Thanks.
Cameron.
On Fri, 10 Jan 2020 at 02:54, Nghia Tran notifications@github.com wrote:
@NghiaTranUIT commented on GitHub (Jan 10, 2020):
Thank for the valuable hint. I'm on it now 👍 Will send you a hot-fix build this weekend 🌮
@cameroncooke commented on GitHub (Jan 10, 2020):
Amazing thank you.
@NghiaTranUIT commented on GitHub (Jan 13, 2020):
Hey @cameroncooke, here is the BETA build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.13.1_Repeat_Request_Bug.dmg
I will officially roll out in a next release 👍
@cameroncooke commented on GitHub (Jan 13, 2020):
Hi Nghia, worked a treat, thanks so much for the quick fix.
Cameron.
On Mon, 13 Jan 2020 at 06:09, Nghia Tran notifications@github.com wrote:
@NghiaTranUIT commented on GitHub (Jan 14, 2020):
Glad to hear that 👍
@NghiaTranUIT commented on GitHub (Jan 21, 2020):
Just friendly reminder that Proxman 1.14.0 is released https://github.com/ProxymanApp/Proxyman/releases/tag/1.14.0.
Let update it 👍