starred/Proxyman
1
0
Fork 0
mirror of https://github.com/ProxymanApp/Proxyman.git synced 2026-04-26 00:25:56 +03:00
Code Issues 1.2k Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #301] [BUG] Too many digits on Request / Response Body Size #297

New issue
Closed
opened 2026-03-03 19:17:13 +03:00 by kerem · 8 comments
kerem commented 2026-03-03 19:17:13 +03:00
Owner
Copy link

Originally created by @NghiaTranUIT on GitHub (Oct 14, 2019).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/301

Originally assigned to: @NghiaTranUIT on GitHub.

🐶 Brief

In the latest version, they request and response body size have many redundant digits.

Screen Shot 2019-10-14 at 23 03 26

👑 Criteria

  • Should be round to 1 floating digit
Originally created by @NghiaTranUIT on GitHub (Oct 14, 2019). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/301 Originally assigned to: @NghiaTranUIT on GitHub. ## 🐶 Brief In the latest version, they request and response body size have many redundant digits. <img width="1496" alt="Screen Shot 2019-10-14 at 23 03 26" src="https://user-images.githubusercontent.com/5878421/66765817-e857f000-eed6-11e9-866a-5c281aa06e16.png"> ## 👑 Criteria - [ ] Should be round to 1 floating digit
kerem 2026-03-03 19:17:13 +03:00
  • closed this issue
  • added the
    bug
         label
kerem commented 2026-03-03 19:17:14 +03:00
Author
Owner
Copy link

@shirshak55 commented on GitHub (Oct 14, 2019):

haha this floating point digit is always pain in ass :) Specially in JS as it only has f64 it even gets more irritating.

<!-- gh-comment-id:541807521 --> @shirshak55 commented on GitHub (Oct 14, 2019): haha this floating point digit is always pain in ass :) Specially in JS as it only has f64 it even gets more irritating.
kerem commented 2026-03-03 19:17:14 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 15, 2019):

In the past, I encountered this floating pain when parsing the number in JSON too (https://github.com/ProxymanApp/Proxyman/issues/169). It's weird that the JSONSerialization class in Foundation framework doesn't handle it properly and our developer have to fix it manually. 😅

<!-- gh-comment-id:542038581 --> @NghiaTranUIT commented on GitHub (Oct 15, 2019): In the past, I encountered this floating pain when parsing the number in JSON too (https://github.com/ProxymanApp/Proxyman/issues/169). It's weird that the JSONSerialization class in Foundation framework doesn't handle it properly and our developer have to fix it manually. 😅
kerem commented 2026-03-03 19:17:14 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 18, 2019):

All done 🎉

Changelogs

  • Fix formatter.maximumFractionDigits in NSNumberFormatter
<!-- gh-comment-id:543459700 --> @NghiaTranUIT commented on GitHub (Oct 18, 2019): All done 🎉 ## Changelogs - Fix `formatter.maximumFractionDigits` in `NSNumberFormatter`
kerem commented 2026-03-03 19:17:14 +03:00
Author
Owner
Copy link

@shirshak55 commented on GitHub (Oct 18, 2019):

@NghiaTranUIT what will happen if the data was actually 70.000000001?

<!-- gh-comment-id:543495665 --> @shirshak55 commented on GitHub (Oct 18, 2019): @NghiaTranUIT what will happen if the data was actually 70.000000001?
kerem commented 2026-03-03 19:17:14 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 18, 2019):

We round it up to 70 (Bytes) 😄

<!-- gh-comment-id:543496185 --> @NghiaTranUIT commented on GitHub (Oct 18, 2019): We round it up to 70 (Bytes) 😄
kerem commented 2026-03-03 19:17:15 +03:00
Author
Owner
Copy link

@shirshak55 commented on GitHub (Oct 18, 2019):

hmm i am that is problem right? Lets say I am working on money endpoint and supplied 70.00001 and proxyman made it 70 and i mock that response to test api server now it will fail because my api server consumer expects it to be 70.00001 not 70 . SO I think proxy man should serve same response given by server and should not roundup etc.

<!-- gh-comment-id:543504570 --> @shirshak55 commented on GitHub (Oct 18, 2019): hmm i am that is problem right? Lets say I am working on money endpoint and supplied 70.00001 and proxyman made it 70 and i mock that response to test api server now it will fail because my api server consumer expects it to be 70.00001 not 70 . SO I think proxy man should serve same response given by server and should not roundup etc.
kerem commented 2026-03-03 19:17:15 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 18, 2019):

The size of the response remains as it is (70.00001) and your Test API server won't be failed. It only rounds up for the presenter on the flow panel.

If we need the precise value, I suppose that I would implement the Summary tab, which presents all essential data without round up.

<!-- gh-comment-id:543568367 --> @NghiaTranUIT commented on GitHub (Oct 18, 2019): The size of the response remains as it is (70.00001) and your Test API server won't be failed. It only rounds up for the presenter on the flow panel. If we need the precise value, I suppose that I would implement the Summary tab, which presents all essential data without round up.
kerem commented 2026-03-03 19:17:15 +03:00
Author
Owner
Copy link

@shirshak55 commented on GitHub (Oct 18, 2019):

i mean if i save response to disk will it modify according to presenter or it will save response as it should?

<!-- gh-comment-id:543572133 --> @shirshak55 commented on GitHub (Oct 18, 2019): i mean if i save response to disk will it modify according to presenter or it will save response as it should?
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
6.9.0
6.8.0
6.7.0
6.6.0
6.5.0
6.4.0
6.3.0
6.2.0
6.1.0
6.0.2
6.0.0
6.0.1
5.25.0
5.24.0
5.23.0
5.23.1
5.22.0
5.20.0
5.21.0
5.19.0
5.18.0
5.17.0
5.16.0
5.15.0
5.14.0
5.12.2
5.12.1
5.12.0
5.11.0
5.10.0
5.8.0
5.9.0
5.7.0
5.6.1
5.6.0
5.5.0
5.4.0
5.2.0
5.3.0
5.1.1
5.0.0
4.16.0
4.15.0
4.14.0
4.13.0
4.12.0
4.11.0
4.10.0
4.9.1
4.9.0
4.8.2
4.8.1
4.8.0
4.7.1
4.7.0
4.6.1
4.6.0
4.5.0
4.4.0
4.3.1
4.3.0
4.2.1
4.2.0
4.1.0
4.0.0
3.15.0
3.14.0
3.13.0
3.12.0
3.11.0
3.10.0
3.9.0
3.8.0
3.7.0
3.6.2
3.6.1
3.6.0
3.5.2
3.5.1
3.5.0
3.4.0
3.3.0
3.2.0
3.1.0
3.0.0
2.35.4
2.35.3
2.35.2
2.35.1
2.35.0
2.34.1
2.34.0
2.33.0
2.32.1
2.32.0
2.31.0
2.30.0
2.29.0
2.28.0
2.27.0
2.26.0
2.25.0
2.24.0
2.23.0
2.22.0
2.21.1
2.21.0
2.20.0
2.19.0
2.18.0
2.17.0
2.16.1
2.16.0
2.15.2
2.15.1
2.15.0
2.14.2
2.14.1
2.14.0
2.13.0
2.12.0
2.11.1
2.11.0
2.10.0
2.9.1
2.9.0
2.8.0
2.7.0
2.6.0
2.5.3
2.5.2
2.5.1
2.5.0
2.4.2
2.4.1
2.4.0
2.3.0
2.2.0
2.1.1
2.1.0
2.0.1
2.0.0
1.24.0
1.23.0
1.22.0
1.21.0
1.20.0
1.19.0
1.18.1
1.18.0
1.17.1
1.17.0
1.16.0
1.15.0
1.14.1
1.14.0
1.13.1
1.13.0
1.12.0
1.11.0
1.10.0
1.9.3
1.9.2
1.9.1
1.9.0
1.8.0
1.7.2
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.1
1.5.0
1.4.7
1.4.6
1.4.5.1
1.4.5
1.4.4.1
1.4.4
1.4.3
1.4.2
1.4.1.1
1.4.1
1.4
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4.3
1.3.4.2
1.3.4.1
1.3.4
1.3.3
1.3.2
1.3.1
1.3
1.2
1.1.2
1.1.1
1.1
1.0.3
1.0.2
1.0
0.8.1
0.8
0.7
0.6
0.5.1
0.5
v0.4.1
Labels
Clear labels   
Discussion

   
Feature request

   
In Progress...

   
Plugins

   
Waiting response

   
Windows

   
Windows

   
bug

   
duplicate

   
enhancement

   
feature

   
good first issue

   
iOS

   
macOS 10.11

   
question

   
wontfix

   
✅ Done
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#297
No description provided.