[GH-ISSUE #294] [BUG] Invalid cookie due to missing the space #292

New issue

Closed

opened 2026-03-03 19:17:09 +03:00 by kerem · 1 comment

kerem commented

2026-03-03 19:17:09 +03:00

Owner

Originally created by @NghiaTranUIT on GitHub (Oct 5, 2019).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/294

Originally assigned to: @NghiaTranUIT on GitHub.

🐶 Brief

Some users reports that Set-Cookie doesn't separate the sub-cookies correctly by missing the space.

For instance,

"Set-Cookie" = "key=value; path=/; httponly, key=value; path=/; httponly;"

"Set-Cookie" = "key=value; path=/; httponly,key=value; path=/; httponly;"

causes that the iOS doesn't recognize the second cookie.

👑 Criteria

Double check the between each cookie in Set-Cookie
Make sure it works

Originally created by @NghiaTranUIT on GitHub (Oct 5, 2019). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/294 Originally assigned to: @NghiaTranUIT on GitHub. ## 🐶 Brief Some users reports that `Set-Cookie` doesn't separate the sub-cookies correctly by missing the space. For instance, ``` "Set-Cookie" = "key=value; path=/; httponly, key=value; path=/; httponly;" ``` vs ``` "Set-Cookie" = "key=value; path=/; httponly,key=value; path=/; httponly;" ``` causes that the iOS doesn't recognize the second cookie. ## 👑 Criteria - [ ] Double check the <space> between each cookie in `Set-Cookie` - [ ] Make sure it works

kerem

2026-03-03 19:17:09 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-03 19:17:10 +03:00

Author

Owner

@NghiaTranUIT commented on GitHub (Oct 5, 2019):

All done 🌮

It turns out that we shouldn't store HTTPHeaders in a dictionary for quick lookup, because dictionary will override the value, which has a same key name.

🤯 Changelogs

Update Telegraph to use mapHeader (lookup table) and array to store headers
Remove manually parsing the Set-Cookie
Treat all keys as an array
Fix missing duplicated key in Breakpoint

Hot-fix

https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.6.2_http_header_fix.dmg

@NghiaTranUIT commented on GitHub (Oct 5, 2019): All done 🌮 It turns out that we shouldn't store HTTPHeaders in a dictionary for quick lookup, because dictionary will override the value, which has a same key name. ## 🤯 Changelogs - [x] Update Telegraph to use mapHeader (lookup table) and array to store headers - [x] Remove manually parsing the Set-Cookie - [x] Treat all keys as an array - [x] Fix missing duplicated key in Breakpoint ## Hot-fix https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.6.2_http_header_fix.dmg