mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 00:25:56 +03:00
[GH-ISSUE #272] Doesn't restore proxy settings correctly. #270
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#270
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @drekka on GitHub (Sep 6, 2019).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/272
Proxyman version? (Ex. Proxyman 1.4.3)
1.5.1
macOS Version? (Ex. mac 10.14)
10.14.6
Steps to reproduce
Expected behavior
At step 2 Proxyman should disable the current proxy setup and enable itself ✔️
At step 3 Proxyman should remove itself ✔️
Also at step 3 Proxyman should restore the previous settings. ❌
Discussion
When I look at the settings after Proxyman has stopped, I can see that the URL is still present, but Proxyman has not activated it again. All I have to do is to tick the setting and apply it. So I'm thinking this is probably not a hard thing to fix given Proxyman already manipulates the settings to start with.
@NghiaTranUIT commented on GitHub (Sep 6, 2019):
Thank for detail report. I'm able to reproduce it too 👍
I'm going to fix and send you a hotfix soon.
@NghiaTranUIT commented on GitHub (Sep 9, 2019):
Hey @drekka, here is hot-fix build for this bug: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.6.0_Helper_Tool_1.0.3.dmg
Basically, I save the original proxy config before overriding, and reverting the setting back later.
Let check it out and give me a 👍 if it works for you ☕️
@drekka commented on GitHub (Sep 11, 2019):
Awesome. It's now correctly setting and unsetting the proxy settings include restoring the setting of the Automatic Proxy Configuration. Thanks. 👍👍👍👍
@NghiaTranUIT commented on GitHub (Sep 11, 2019):
Glad to hear that @drekka 🌮 . I will officially ship the fix in next release 👍
@NghiaTranUIT commented on GitHub (Sep 14, 2019):
I would close this ticket and prepare for next release 👍
@mazgajmaciek commented on GitHub (Jul 8, 2022):
@NghiaTranUIT this somehow doesn't work for me still (it doesn't turn back on Automatic Proxy Configuration when I turn Proxyman off). I'm using:
@NghiaTranUIT commented on GitHub (Nov 14, 2024):
@mazgajmaciek It's fixed in this Beta build: https://github.com/ProxymanApp/Proxyman/issues/2155#issuecomment-2475843960