[GH-ISSUE #269] [BUG] Invalid forward URL-encoded #266

Closed
opened 2026-03-03 19:16:56 +03:00 by kerem · 1 comment
Owner

Originally created by @NghiaTranUIT on GitHub (Sep 1, 2019).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/269

Originally assigned to: @NghiaTranUIT on GitHub.

🐶 Brief

For some reason, when we construct the raw HTTP message, we accidentally remove percent encoding before sending to the server.

Ex:

  • Post via Proxyman
https://httpbin.org/get?data=123+nghiatran&email=account%2Balias%40gmail.com&search[category]=all&title=好

will receive

https://httpbin.org/get?data=123+nghiatran&email=account+alias%40gmail.com&search[category]=all&title=好

Expected

https://httpbin.org/get?data=123%2Bnghiatran&email=account%2Balias%40gmail.com&search[category]=all&title=好

👑 Criteria

  • Keep the URL-encoded when receiving through the socket
  • Send forward by same data, dont' manipulate it
  • Fix PrettyURL label for prettifying the URL correctly
  • Bug: When composing -> If the query has invalid chars -> Couldn't prettify the URL
Originally created by @NghiaTranUIT on GitHub (Sep 1, 2019). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/269 Originally assigned to: @NghiaTranUIT on GitHub. ## 🐶 Brief For some reason, when we construct the raw HTTP message, we accidentally remove percent encoding before sending to the server. Ex: - Post via Proxyman ``` https://httpbin.org/get?data=123+nghiatran&email=account%2Balias%40gmail.com&search[category]=all&title=好 ``` will receive ``` https://httpbin.org/get?data=123+nghiatran&email=account+alias%40gmail.com&search[category]=all&title=好 ``` ## Expected ``` https://httpbin.org/get?data=123%2Bnghiatran&email=account%2Balias%40gmail.com&search[category]=all&title=好 ``` ## 👑 Criteria - [ ] Keep the URL-encoded when receiving through the socket - [ ] Send forward by same data, dont' manipulate it - [ ] Fix PrettyURL label for prettifying the URL correctly - [ ] Bug: When composing -> If the query has invalid chars -> Couldn't prettify the URL
kerem 2026-03-03 19:16:56 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@NghiaTranUIT commented on GitHub (Sep 1, 2019):

🤯 Changelogs

  • Respect the raw message from socket -> Don't decode Percent-encoded URL
  • When constructing the raw HTTP message for Breakpoint -> Use URLEncoding in Alamofire to do a transform properly
  • Fix couldn't render the URL Prettier
  • Fix Couldn't update URL when updating query in Breakpoint
<!-- gh-comment-id:526886629 --> @NghiaTranUIT commented on GitHub (Sep 1, 2019): ## 🤯 Changelogs - [x] Respect the raw message from socket -> Don't decode Percent-encoded URL - [x] When constructing the raw HTTP message for Breakpoint -> Use URLEncoding in Alamofire to do a transform properly - [x] Fix couldn't render the URL Prettier - [x] Fix Couldn't update URL when updating query in Breakpoint
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#266
No description provided.