[GH-ISSUE #263] [Feature] Filter by resource type #261

Closed
opened 2026-03-03 19:16:49 +03:00 by kerem · 15 comments
Owner

Originally created by @neofight78 on GitHub (Aug 26, 2019).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/263

Originally assigned to: @NghiaTranUIT on GitHub.

It would be great to be able to quickly filter by resource type as in the Safari inspector. Usually I don't want to see all the image requests for example.

image

Originally created by @neofight78 on GitHub (Aug 26, 2019). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/263 Originally assigned to: @NghiaTranUIT on GitHub. It would be great to be able to quickly filter by resource type as in the Safari inspector. Usually I don't want to see all the image requests for example. ![image](https://user-images.githubusercontent.com/221644/63698022-514bb180-c81e-11e9-8483-208f6d8b2198.png)
kerem 2026-03-03 19:16:49 +03:00
Author
Owner

@shirshak55 commented on GitHub (Aug 26, 2019):

yea and most of the time I just want to totally exclude image, font etc. :(

<!-- gh-comment-id:524929183 --> @shirshak55 commented on GitHub (Aug 26, 2019): yea and most of the time I just want to totally exclude image, font etc. :(
Author
Owner

@NghiaTranUIT commented on GitHub (Aug 27, 2019):

Related to #251 and #164.

I guess I could quickly support the "filter" by introducing the lightweight By-Pass list (wildcard support). Thus, *.jpg or whatever you like could be ignore in entire Proxyman, and less distraction 😄

If you like it, I could push it forward in Proxyman 1.6.0 (next release)

<!-- gh-comment-id:525115712 --> @NghiaTranUIT commented on GitHub (Aug 27, 2019): Related to #251 and #164. I guess I could quickly support the "filter" by introducing the lightweight By-Pass list (wildcard support). Thus, *.jpg or whatever you like could be ignore in entire Proxyman, and less distraction 😄 If you like it, I could push it forward in Proxyman 1.6.0 (next release)
Author
Owner

@neofight78 commented on GitHub (Aug 27, 2019):

While obviously the linked features offer a lot of power, what’s needed is a quick way to cover what must be a common scenario, rather than having to configure from scratch. So whatever mechanism is used, including wildcards, some default presets would be the way to go. Filtering on mime type would seem to be what’s needed.

Obviously the sooner you can implement the better as far as I am concerned 😉

<!-- gh-comment-id:525125840 --> @neofight78 commented on GitHub (Aug 27, 2019): While obviously the linked features offer a lot of power, what’s needed is a quick way to cover what must be a common scenario, rather than having to configure from scratch. So whatever mechanism is used, including wildcards, some default presets would be the way to go. Filtering on mime type would seem to be what’s needed. Obviously the sooner you can implement the better as far as I am concerned 😉
Author
Owner

@NghiaTranUIT commented on GitHub (Aug 27, 2019):

Agree with you @neofight. I would ship the MVP version of smart folder as a simple Filter (like Safari) on specific Folder for you as a simple needed.

For instance,

  • Right click on Folder, Domain, Node -> Filter Menu -> Select the filter type (it could be All | APIs | Image | .... ).

I will ship it in next version 👍

<!-- gh-comment-id:525132533 --> @NghiaTranUIT commented on GitHub (Aug 27, 2019): Agree with you @neofight. I would ship the MVP version of smart folder as a simple Filter (like Safari) on specific Folder for you as a simple needed. For instance, - Right click on Folder, Domain, Node -> Filter Menu -> Select the filter type (it could be All | APIs | Image | .... ). I will ship it in next version 👍
Author
Owner

@NghiaTranUIT commented on GitHub (Sep 1, 2019):

The feature is done. I'm going to release soon 🥇

<!-- gh-comment-id:526886652 --> @NghiaTranUIT commented on GitHub (Sep 1, 2019): The feature is done. I'm going to release soon 🥇
Author
Owner

@shirshak55 commented on GitHub (Sep 1, 2019):

wow will wait for it to test it

<!-- gh-comment-id:526925912 --> @shirshak55 commented on GitHub (Sep 1, 2019): wow will wait for it to test it
Author
Owner

@NghiaTranUIT commented on GitHub (Sep 4, 2019):

All done 👍

🤯 Changelogs

  • Introduce Filter Panel on top of Flow List (CMD+F)
  • Able to filter by URL or Content Type
  • Work with sorting
  • Support selection label in bottom of Toolbar
Screen Shot 2019-09-04 at 23 22 13
<!-- gh-comment-id:527978952 --> @NghiaTranUIT commented on GitHub (Sep 4, 2019): All done 👍 ## 🤯 Changelogs - [x] Introduce Filter Panel on top of Flow List (CMD+F) - [x] Able to filter by URL or Content Type - [x] Work with sorting - [x] Support selection label in bottom of Toolbar <img width="1161" alt="Screen Shot 2019-09-04 at 23 22 13" src="https://user-images.githubusercontent.com/5878421/64273199-055de280-cf6b-11e9-86f1-0117e5f2185a.png">
Author
Owner

@NghiaTranUIT commented on GitHub (Sep 4, 2019):

Hey @shirshak55 @neofight , let check the Filter BETA at https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.5.1_Filter.dmg

I would release tmr if everything is good. 👍

<!-- gh-comment-id:527984626 --> @NghiaTranUIT commented on GitHub (Sep 4, 2019): Hey @shirshak55 @neofight , let check the Filter BETA at https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.5.1_Filter.dmg I would release tmr if everything is good. 👍
Author
Owner

@neofight78 commented on GitHub (Sep 4, 2019):

A few quick observations:

  • 404 images always get classified as a document (because the returned mime type to text/html)
  • Ajax requests end up in the document tab rather than the XHR tab
  • A have an SVG which is returned from the server without a mime type so it gets classified as a document.
  • JS & CSS should have their own tabs

Maybe worth looking at the accept header of the request to help determine the file type? E.g.

CleanShot 2019-09-04 at 18 52 37@2x
<!-- gh-comment-id:527991366 --> @neofight78 commented on GitHub (Sep 4, 2019): A few quick observations: * 404 images always get classified as a document (because the returned mime type to text/html) * Ajax requests end up in the document tab rather than the XHR tab * A have an SVG which is returned from the server without a mime type so it gets classified as a document. * JS & CSS should have their own tabs Maybe worth looking at the accept header of the request to help determine the file type? E.g. <img width="308" alt="CleanShot 2019-09-04 at 18 52 37@2x" src="https://user-images.githubusercontent.com/221644/64275152-375c4e00-cf45-11e9-8bd1-a35ae8b4927b.png">
Author
Owner

@NghiaTranUIT commented on GitHub (Sep 5, 2019):

Thank for quick feedback @neofight. I'd take the accept header to determine which group should be. Other issues are correct and will be fix before releasing.

However, the concern is that It's possible to detect the Ajax requests since Proxyman is just MiTM, not Google Chrome, who know where the requests are from. Currently, all JSON, XML, www-form are belonging to XHR tab, and it seems to be incorrect, since other requests (maybe text/) could be too.

I guess I should remove the XHR tab and introduce JSON, XML, FORM, JS and CSS tab.

<!-- gh-comment-id:528186500 --> @NghiaTranUIT commented on GitHub (Sep 5, 2019): Thank for quick feedback @neofight. I'd take the accept header to determine which group should be. Other issues are correct and will be fix before releasing. However, the concern is that It's possible to detect the Ajax requests since Proxyman is just MiTM, not Google Chrome, who know where the requests are from. Currently, all JSON, XML, www-form are belonging to XHR tab, and it seems to be incorrect, since other requests (maybe text/) could be too. I guess I should remove the XHR tab and introduce JSON, XML, FORM, JS and CSS tab.
Author
Owner

@neofight78 commented on GitHub (Sep 5, 2019):

Regarding XHR I suspect you are right, so I agree it's probably best to remove the tab. Personally I'd just have JSON, XML, FORM under the document tab rather than create new ones. Generally as a web developer I want to separate out pages / dynamic content from all the static resources such as images, css etc.

<!-- gh-comment-id:528231774 --> @neofight78 commented on GitHub (Sep 5, 2019): Regarding XHR I suspect you are right, so I agree it's probably best to remove the tab. Personally I'd just have JSON, XML, FORM under the document tab rather than create new ones. Generally as a web developer I want to separate out pages / dynamic content from all the static resources such as images, css etc.
Author
Owner

@NghiaTranUIT commented on GitHub (Sep 5, 2019):

From your feedback, I've fixed and released new version of Global Filter bar @neofight at https://github.com/ProxymanApp/Proxyman/releases/tag/1.6.0

You can update directly from the app. Let check it out 😄

<!-- gh-comment-id:528423787 --> @NghiaTranUIT commented on GitHub (Sep 5, 2019): From your feedback, I've fixed and released new version of Global Filter bar @neofight at https://github.com/ProxymanApp/Proxyman/releases/tag/1.6.0 You can update directly from the app. Let check it out 😄
Author
Owner

@neofight78 commented on GitHub (Sep 5, 2019):

Looks nice, one issue still remains (again should be resolvable by looking at file extension / accept headers):

  • When an image url returns 404 it gets classified as a document (because the returned mime type to text/html)

Also, this is a bit nit picky I know, but I don't like "Doc" and "Img" as a tab names, maybe just use the full words?

<!-- gh-comment-id:528437311 --> @neofight78 commented on GitHub (Sep 5, 2019): Looks nice, one issue still remains (again should be resolvable by looking at file extension / accept headers): * When an image url returns 404 it gets classified as a document (because the returned mime type to text/html) Also, this is a bit nit picky I know, but I don't like "Doc" and "Img" as a tab names, maybe just use the full words?
Author
Owner

@NghiaTranUIT commented on GitHub (Sep 6, 2019):

I deliberately make the label shorter since it could take less space to present entire filter bar.
I will double check the 404-case and make the title is full since it makes more sense 👍

<!-- gh-comment-id:528760574 --> @NghiaTranUIT commented on GitHub (Sep 6, 2019): I deliberately make the label shorter since it could take less space to present entire filter bar. I will double check the 404-case and make the title is full since it makes more sense 👍
Author
Owner

@shirshak55 commented on GitHub (Sep 6, 2019):

Yea short is nice by the way. Anyway we can add advance filters in left
side so user can name their filter anyway in future :)

On Fri, Sep 6, 2019 at 1:49 PM Nghia Tran notifications@github.com wrote:

I deliberately make the label shorter since it could take less space to
present entire filter bar.
I will double check the 404-case and make the title is full since it makes
more sense 👍


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ProxymanApp/Proxyman/issues/263?email_source=notifications&email_token=AB5Y4YKUANGTUFU743Z3VSDQIIHBXA5CNFSM4IPQKTB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6CD57Q#issuecomment-528760574,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB5Y4YM5ZDPTZ7EMM6NHXGTQIIHBXANCNFSM4IPQKTBQ
.

<!-- gh-comment-id:528761424 --> @shirshak55 commented on GitHub (Sep 6, 2019): Yea short is nice by the way. Anyway we can add advance filters in left side so user can name their filter anyway in future :) On Fri, Sep 6, 2019 at 1:49 PM Nghia Tran <notifications@github.com> wrote: > I deliberately make the label shorter since it could take less space to > present entire filter bar. > I will double check the 404-case and make the title is full since it makes > more sense 👍 > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/ProxymanApp/Proxyman/issues/263?email_source=notifications&email_token=AB5Y4YKUANGTUFU743Z3VSDQIIHBXA5CNFSM4IPQKTB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6CD57Q#issuecomment-528760574>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AB5Y4YM5ZDPTZ7EMM6NHXGTQIIHBXANCNFSM4IPQKTBQ> > . >
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#261
No description provided.