mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 00:25:56 +03:00
[GH-ISSUE #231] Cleanup Certificates on close? #228
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#228
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @psimoneau22 on GitHub (Jul 29, 2019).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/231
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
macOS Version? (Ex. mac 10.14)
10.13.6 (High Sierra)
Steps to reproduce
Open proxyman. Navigate to any url with browser. Select Enable for All Domains in Proxyman.
Close proxyman. Check Keychain. Proxyman CA issued certificates for every domain accessed still exist
Expected behavior
Keychain certificates should be left in the same state they were before the app was opened, removing all Proxyman issued certs.
I would have expected the app to clean up the system when it is done. Its not a big deal, but I am just wondering if it is possible, and why it works the way it does.
Screenshots (optional)
@NghiaTranUIT commented on GitHub (Jul 30, 2019):
Hey, that's really valid point. Thank you for pointing it out 👍
I will take it into account in Proxyman 1.5.0. Right now, the
re-mapn response from fileis on the way.@NghiaTranUIT commented on GitHub (Nov 7, 2019):
So, I figured out how we solve this issues.
Technically, Proxyman is using
SecPKCS12ImportfromSecurityframework to read the p12 files , then extracting the pubic and private keys. It's crucial for SSL Handshaking between Proxyman and the client. However,SecPKCS12Importimport the cert to the KeyChain by default.I researched
SecItemImport, and the result is same without touching to the KeyChain. I will release the fix in next release 1.9.0 👍Thank you for pointing it out 😄
Ref:
@psimoneau22 commented on GitHub (Nov 7, 2019):
this is great, thank you!
@NghiaTranUIT commented on GitHub (Nov 8, 2019):
All done 🎉
🤯 Changelogs
Here is the BETA: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.8.0_Keychain_issues.dmg
I will officially release in this weekend or next week at least 👍 😄