[GH-ISSUE #213] Missing multiple "Set-Cookie" key in Header #210

Closed
opened 2026-03-03 19:16:15 +03:00 by kerem · 6 comments
Owner

Originally created by @NghiaTranUIT on GitHub (Jul 10, 2019).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/213

Originally assigned to: @NghiaTranUIT on GitHub.

🐶 Brief

Some users reported that if the header has many Set-Cookie, Proxyman only captures the last one. It happens in Request and Response too.

Technically, Proxyman store key-value of header as a Dictionary, so it overrides if it's same key. We should fix it.

👑 Criteria

  • The header shouldn't be override
  • Retain the order of key when sending (current behavior)
Originally created by @NghiaTranUIT on GitHub (Jul 10, 2019). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/213 Originally assigned to: @NghiaTranUIT on GitHub. ## 🐶 Brief Some users reported that if the header has many `Set-Cookie`, Proxyman only captures the last one. It happens in Request and Response too. Technically, Proxyman store key-value of header as a Dictionary, so it overrides if it's same key. We should fix it. ## 👑 Criteria - [ ] The header shouldn't be override - [ ] Retain the order of key when sending (current behavior)
kerem 2026-03-03 19:16:15 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@NghiaTranUIT commented on GitHub (Jul 13, 2019):

All done 🎉

🤯 Changelogs

  • Support duplicated header in HTTP Message: Ex: Set-Cookie
  • When parsing Header when composing/repeating -> Should compose those duplicated values by ,
    Screen Shot 2019-07-13 at 15 12 36
<!-- gh-comment-id:511101183 --> @NghiaTranUIT commented on GitHub (Jul 13, 2019): All done 🎉 ## 🤯 Changelogs - [x] Support duplicated header in HTTP Message: Ex: Set-Cookie - [x] When parsing Header when composing/repeating -> Should compose those duplicated values by `,` <img width="789" alt="Screen Shot 2019-07-13 at 15 12 36" src="https://user-images.githubusercontent.com/5878421/61169000-ac805800-a580-11e9-872d-11c9c17140ab.png">
Author
Owner

@Demmy27 commented on GitHub (Aug 26, 2019):

Set-Cookie: JSESSIONID=9d4fcef1-4617-43c8--d4054136fafc; Domain=..ru; Path=/; Secure; HttpOnly
Set-Cookie: auid=60ad9ed5-36a5-43a4--20961c7e810f; Domain=..ru; Expires=Tue
Set-Cookie: 25-Aug-2020 08:13:41 GMT; Path=/
Set-Cookie: srv_id=hbs-front04-prod; expires=Mon
Set-Cookie: 26-Aug-19 16:13:41 GMT; max-age=28800; domain=..ru; path=/
Set-Cookie: _uid=aa8649c7-452d-4b25--b428a69bbe9e; Path=/; Domain=.
.ru
Set-Cookie: ****sid=s%3Ac6EzwiUTdJFxatRtz77fXhAY6hp.PagGl2OXcyMmSyoqpuYWCxJDtXWxaEEc23FQ0qNhtns; Domain=..ru; Path=/; HttpOnly; Secure

<!-- gh-comment-id:524793520 --> @Demmy27 commented on GitHub (Aug 26, 2019): Set-Cookie: JSESSIONID=9d4fcef1-4617-43c8-****-d4054136fafc; Domain=.****.ru; Path=/; Secure; HttpOnly Set-Cookie: auid=60ad9ed5-36a5-43a4-****-20961c7e810f; Domain=.****.ru; Expires=Tue Set-Cookie: 25-Aug-2020 08:13:41 GMT; Path=/ Set-Cookie: srv_id=hbs-front04-prod; expires=Mon Set-Cookie: 26-Aug-19 16:13:41 GMT; max-age=28800; domain=.****.ru; path=/ Set-Cookie: ****_uid=aa8649c7-452d-4b25-****-b428a69bbe9e; Path=/; Domain=.****.ru Set-Cookie: ****_sid=s%3Ac6EzwiUTdJFxa_****tRtz77fXhAY6hp.PagGl2OXcyMmSyoqpuYWCxJDtXWxaEEc23FQ0qNhtns; Domain=.****.ru; Path=/; HttpOnly; Secure
Author
Owner

@Demmy27 commented on GitHub (Aug 26, 2019):

wrong word wrap - "Set-Cookie: 25-Aug-2020 08:13:41 GMT; Path=/"

<!-- gh-comment-id:524793862 --> @Demmy27 commented on GitHub (Aug 26, 2019): wrong word wrap - "Set-Cookie: 25-Aug-2020 08:13:41 GMT; Path=/"
Author
Owner

@NghiaTranUIT commented on GitHub (Aug 26, 2019):

Thank for the report @Demmy27. I open this ticket again and look on it today 👍

<!-- gh-comment-id:524843660 --> @NghiaTranUIT commented on GitHub (Aug 26, 2019): Thank for the report @Demmy27. I open this ticket again and look on it today 👍
Author
Owner

@NghiaTranUIT commented on GitHub (Sep 1, 2019):

Hey @Demmy27, please download the latest version 1.5.1 Proxyman at https://github.com/ProxymanApp/Proxyman/releases/tag/1.5.1 since I couldn't reproduce it bug anymore.

<!-- gh-comment-id:526880333 --> @NghiaTranUIT commented on GitHub (Sep 1, 2019): Hey @Demmy27, please download the latest version 1.5.1 Proxyman at https://github.com/ProxymanApp/Proxyman/releases/tag/1.5.1 since I couldn't reproduce it bug anymore.
Author
Owner

@NghiaTranUIT commented on GitHub (Sep 4, 2019):

Closed because we couldn't reproduce it anymore in latest version 👍

<!-- gh-comment-id:527979181 --> @NghiaTranUIT commented on GitHub (Sep 4, 2019): Closed because we couldn't reproduce it anymore in latest version 👍
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#210
No description provided.