mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-25 16:15:55 +03:00
[GH-ISSUE #1763] POST data not properly escaped when exporting as cURL command #1756
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#1756
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @seidnerj on GitHub (Sep 6, 2023).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1763
Originally assigned to: @NghiaTranUIT on GitHub.
Description
POST may not be properly escaped when exporting as cURL command.
Steps to Reproduce
Take a request with the post take containing an apostrophe, copy as cURL and try to run from the command line.
Current Behavior
If the post data of a request has an apostrophe in it, it is not escaped.
Expected Behavior
An apostrophe should be escaped as the post data is already enclosed in apostrophes.
Environment
@NghiaTranUIT commented on GitHub (Sep 7, 2023):
@seidnerj if you don't mind, can you provide an cURL example, so I can test it easily 🤔
@seidnerj commented on GitHub (Sep 7, 2023):
Sure, you can use the example below.
This is a proper cURL command with apostrophe escaped:
And the below is what you get when you copy as cURL from the Proxyman UI:
See how
nel'immagineappears instead ofnel'\''immagine.Thanks!
@NghiaTranUIT commented on GitHub (Sep 7, 2023):
Thanks for the detailed example. I'm going to fix it now 👍
@seidnerj commented on GitHub (Sep 7, 2023):
Awesome, thanks!
@NghiaTranUIT commented on GitHub (Sep 7, 2023):
@seidnerj it's fixed. Here is the Beta build: https://download.proxyman.io/beta/Proxyman_4.10.0_fix_escape_string_in_curl.dmg
Thanks again for reporting the bug 👍
@seidnerj commented on GitHub (Sep 7, 2023):
Thanks! I am already using another beta for the webkit ssl issue, does the above version include both fixes?
@NghiaTranUIT commented on GitHub (Sep 8, 2023):
Yes, it's included too @seidnerj